Maven 2.x Project Info Reports Plugin

Refactoring of dependency and dependency management report

Details

  • Patch Submitted:
    Yes
  • Number of attachments :
    3

Description

I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code.

Important improvements:

  • Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer.
    If this patch is accepted, I want to write all the renderers out of the inforeports in separate classes, with more code sharing. This is a start of that.
  • I changed the unit tests, because the expected and actual were reversed. This is the case in many of the info report unit tests.

Please tell me what you think of it. I know it is only a start.

  1. Text File
    comparators.patch
    05/Mar/08 5:03 PM
    27 kB
    Nick Stolwijk
  2. Text File
    refactor.patch
    05/Mar/08 5:02 PM
    114 kB
    Nick Stolwijk
  3. Text File
    refactor.patch
    04/Mar/08 4:31 PM
    114 kB
    Nick Stolwijk

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

IMHO it is a good work. Thanks!

I have some comments on the code:

  • I dont like AbstractDependencies#getScope(Object) Why not using getScope() directly ?
  • could you provide some test cases for new comparator classes?

Some comments on the Maven code convention:

  • we don't use final at all, specially in methods definition/signature
  • could you separated public/protected/private in each class to make the code more readingness?
  • could you comment a minimum with javadoc, specially abstract classes? Btw it is $Id: $ (with colon) for the @version tag

I think you could go ahead.

Show
Vincent Siveton added a comment - IMHO it is a good work. Thanks! I have some comments on the code: I dont like AbstractDependencies#getScope(Object) Why not using getScope() directly ? could you provide some test cases for new comparator classes? Some comments on the Maven code convention: we don't use final at all, specially in methods definition/signature could you separated public/protected/private in each class to make the code more readingness? could you comment a minimum with javadoc, specially abstract classes? Btw it is $Id: $ (with colon) for the @version tag I think you could go ahead.
Hide
Permalink
Vincent Siveton added a comment -

Another thought for the getScope() issue: you could also create a wrapper for Artifact and Dependency

Show
Vincent Siveton added a comment - Another thought for the getScope() issue: you could also create a wrapper for Artifact and Dependency
Hide
Permalink
Nick Stolwijk added a comment -

Contains the Plugin, Artifact and Dependency Comparators for the refactoring, with unit tests.

Show
Nick Stolwijk added a comment - Contains the Plugin, Artifact and Dependency Comparators for the refactoring, with unit tests.
Hide
Permalink
Nick Stolwijk added a comment -

And now the right file.

Added comparators and unit test for them in comparators.patch

Show
Nick Stolwijk added a comment - And now the right file. Added comparators and unit test for them in comparators.patch
Hide
Permalink
Dennis Lundberg added a comment -

Nick, which of the three patch files is it that should be applied? I'm a bit confused...

Show
Dennis Lundberg added a comment - Nick, which of the three patch files is it that should be applied? I'm a bit confused...
Hide
Permalink
Vincent Siveton added a comment -

Hi Nick,
I am working to prepare the release of the MPIR. Could you send us a one-in-one patch? Tx

Show
Vincent Siveton added a comment - Hi Nick, I am working to prepare the release of the MPIR. Could you send us a one-in-one patch? Tx
Hide
Permalink
Herve Boutemy added a comment -

with r1100791, this is the last modification I can see from the patch that can be applied in the actual code

if you have improvements to propose to actual code, please open another issue

Show
Herve Boutemy added a comment - with r1100791 , this is the last modification I can see from the patch that can be applied in the actual code if you have improvements to propose to actual code, please open another issue

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Nick Stolwijk
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: