Add explicit resource bundle for English

If you want to exploit this bug, just run

mvn site -Dlocales=de,en

Note that "de" is placed first to denote the default locale.

It's not clear to me what you are expecting when you run the command above.

Setting the default locale to "de" should render the reports in German, right? Or am I missing something?

I've seen your patches for this in several plugin, and I'm willing to apply them. I just want to understand the problem they are solving

The illustrated command should produce the site output in two different locales, namely German and English (see also Site Guide, Internationalization). Now, when a report plugin does not contain a dedicated bundle for English, the second site output will be using German again instead of English. German being the default locale does not mean that I want all sites in German

I really suggest you go and call Maven as illustrated. Then just browse the two generated sites. German (as being default) should hang around just unter target/site, while the English site lies under target/site/en. Once you see the "English" site yourself, it will all get clear... or not, depending on your knowledge about German

Dennis,
I think also that Benjamin is right. See the related issue.

I also agree. I was about to apply some of Benjamin's patches but got halted by the encoding question, see MPMD-71 and MSITE-287, can someone clarify this?

Here's a very small project that borrows the resource files from MPIR.

It sets the default locale to the first command line parameter. Then it retrieves a resouce bundle for the English locale. Finally it gets a string from the resouce bundle and prints it.

Run it using these commands:

mvn package
java -jar target\MPIR-79-1.0-SNAPSHOT.jar <defaultLocale>

I have not been able to get it to output anything else that the English text "About", no matter what I throw at it as the default locale. There must be something that I simply do not understand.

It sets the default locale to the first command line parameter.

No, it doesn't You simply assign a variable called "defaultLocale" but the default locale is maintained by the java.util.Locale class. One needs to call setDefault() in order to effectively change it.

I attached a slightly modified version of your test project. The modified code also prints out the effective locale of the bundle that has been retrieved (bundleLocale). Here's my log output:

M:\MPIR-79>java -jar target\MPIR-79-1.0-SNAPSHOT.jar de
defaultLocale=de
locale=en
bundleLocale=de
Willkommen bei

Can I convice you this way?

DOH!

Thanks for being patient with me. I'll start applying patches now...

Never mind, I always appreciate a good discussion as it might provide insights for other readers as well.

Patch applied in r612253 and a new SNAPSHOT has been deployed.
Thank you!