Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0-beta-3, 2.0, 2.0.1
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      2

      Description

      When fo all developers in pom.xml we some property not defined, it is good to not include it to html output.
      Fow example:

      ...
      <developer>
      <id>developer1</id>
      <name>Developer 1</name>
      <email>developer1@email.com</email>
      <roles>
      <role>Project Manager</role>
      <role>Architect</role>
      <role>Java Developer</role>
      </roles>
      <timezone>+2</timezone>
      </developer>
      <developer>
      <id>developer2</id>
      <name>Developer 2</name>
      <email>developer2@email.com</email>
      <roles>
      <role>Java Developer</role>
      </roles>
      <timezone>+2</timezone>
      </developer>
      ...

      For both developers properties like URL, Organization, Organization URL and Properties not specified. In result html we have cells with "-".
      As for me it is good not not include columns where only "-" present at all.

      1. team-list.patch
        21 kB
        Dmitry Kobyleha
      2. TeamListReport.java
        21 kB
        Dmitry Kobyleha

        Issue Links

          Activity

          Hide
          Dmitry Kobyleha added a comment -

          Try my implementation of this issue.

          You can look on 2.0.1 generation there: http://embedchat.org/team-list-old.html
          And on list generated with this change: http://embedchat.org/team-list.html

          Maybe it is useful to make this configurable?

          Show
          Dmitry Kobyleha added a comment - Try my implementation of this issue. You can look on 2.0.1 generation there: http://embedchat.org/team-list-old.html And on list generated with this change: http://embedchat.org/team-list.html Maybe it is useful to make this configurable?
          Hide
          Arik Kfir added a comment -

          I noticed that your patch creates two organization columns - one for the organization name ("Organization") and one for the organization URL ("Organization URL").

          Perhaps it is better to unify them to one column simply called "Organization" that always displays the organization name, but if an organization URL is specified in the POM, that label becomes a link to that URL. This would save some space in the table.

          Show
          Arik Kfir added a comment - I noticed that your patch creates two organization columns - one for the organization name ("Organization") and one for the organization URL ("Organization URL"). Perhaps it is better to unify them to one column simply called "Organization" that always displays the organization name, but if an organization URL is specified in the POM, that label becomes a link to that URL. This would save some space in the table.
          Hide
          Dmitry Kobyleha added a comment -

          I did not want to change basic logic of columns output. I only added verification of blank columns presence. For example on http://embedchat.org/team-list-old.html there are 3 empty columns: "Organization", "Organization URL" and "Properties". In a patch I just remove from output empty columns.

          As about union of "organization" and "organizations url" columns I initially don't think about it.

          Possibly it would be not bad to add some output configuration to plugin options in pom.xml.

          Is there some chance to plug my changes in some next version?

          Show
          Dmitry Kobyleha added a comment - I did not want to change basic logic of columns output. I only added verification of blank columns presence. For example on http://embedchat.org/team-list-old.html there are 3 empty columns: "Organization", "Organization URL" and "Properties". In a patch I just remove from output empty columns. As about union of "organization" and "organizations url" columns I initially don't think about it. Possibly it would be not bad to add some output configuration to plugin options in pom.xml. Is there some chance to plug my changes in some next version?
          Hide
          Vincent Siveton added a comment -

          Hi Dmitry,

          It is better for us to work with svn patch [1]. Could you provide us one?
          Thanks!

          [1] http://maven.apache.org/guides/development/guide-m2-development.html#Creating%20and%20submitting%20a%20patch

          Show
          Vincent Siveton added a comment - Hi Dmitry, It is better for us to work with svn patch [1] . Could you provide us one? Thanks! [1] http://maven.apache.org/guides/development/guide-m2-development.html#Creating%20and%20submitting%20a%20patch
          Hide
          Dmitry Kobyleha added a comment -

          Ok, look at this one

          Show
          Dmitry Kobyleha added a comment - Ok, look at this one
          Hide
          Vincent Siveton added a comment -

          Patch applied with minor changes. Thanks!

          Show
          Vincent Siveton added a comment - Patch applied with minor changes. Thanks!

            People

            • Assignee:
              Vincent Siveton
              Reporter:
              Dmitry Kobyleha
            • Votes:
              5 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: