use of POM artifactId for svn report creates issues when file layout doesn't match artifact names

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

See http://mojo.codehaus.org/webstart-maven-plugin-parent/webstart-maven-plugin/source-repository.html

The webstart project is a multiproject plugin with the following layout:

webstart-maven-plugin/pom.xml (artifactid = webstart-maven-plugin-parent)
webstart-maven-plugin/plugin/pom.xml (artifactid = webstart-maven-plugin)

the ScmReport uses the artifactid and a URL built using the artifactIds to construct the scm report information. E.g. :

private void anonymousAccessSVN( SvnScmProviderRepository svnRepo )

{ paragraph( i18n.getString( "project-info-report", locale, "report.scm.anonymousaccess.svn.intro" ) ); StringBuffer sb = new StringBuffer(); sb.append( "$ svn checkout " ).append( svnRepo.getUrl() ).append( " " ).append( model.getArtifactId() ); verbatimText( sb.toString() ); }

All generated svn information (web, svn command line) is then wrong.

Instead of

https://svn.mojo.codehaus.org/mojo/trunk/mojo/mojo-sandbox/webstart-maven-plugin-parent/webstart-maven-plugin

one should have:

https://svn.mojo.codehaus.org/mojo/trunk/mojo/mojo-sandbox/webstart-maven-plugin/plugin

Etc...

Should I really override all my pom.xml <scm> entries, or should the plugin be smarter and use the file layout instead?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

the plugin shouldn't be smarter. It is using <scm><url/> just as it should. The issue is the confusion caused by the core's appending the artifactId - and there are already open issues to watch there for maven 2.1.

Show
Brett Porter added a comment - the plugin shouldn't be smarter. It is using <scm><url/> just as it should. The issue is the confusion caused by the core's appending the artifactId - and there are already open issues to watch there for maven 2.1.
Hide
Permalink
Jerome Lacoste added a comment -

Brett, I am not sure. I think there are 2 issues. One in the core that makes the url incorrect, i.e. the one you are talking about. The other in the scmreport code. Look at:

http://mojo.codehaus.org/webstart-maven-plugin-parent/source-repository.html

The svn anonymous checkout command (as generated by the code I pasted in the issue's description) is

$ svn checkout https://svn.codehaus.org/mojo/trunk/mojo/mojo-sandbox/webstart-maven-plugin-parent webstart-maven-plugin-parent

There we can see that both the URL and the svn module are wrong. If you fix the URL issue you still have the svn module one. Do you agree? If so could you please reopen?

BTW, do you have issue numbers related to the first issue? I've found MNG-2006 and MNG-2209, but I am sure there are others that match better the issue.

Show
Jerome Lacoste added a comment - Brett, I am not sure. I think there are 2 issues. One in the core that makes the url incorrect, i.e. the one you are talking about. The other in the scmreport code. Look at: http://mojo.codehaus.org/webstart-maven-plugin-parent/source-repository.html The svn anonymous checkout command (as generated by the code I pasted in the issue's description) is $ svn checkout https://svn.codehaus.org/mojo/trunk/mojo/mojo-sandbox/webstart-maven-plugin-parent webstart-maven-plugin-parent There we can see that both the URL and the svn module are wrong. If you fix the URL issue you still have the svn module one. Do you agree? If so could you please reopen? BTW, do you have issue numbers related to the first issue? I've found MNG-2006 and MNG-2209, but I am sure there are others that match better the issue.
Hide
Permalink
Brett Porter added a comment -

I'm not sure of the issue. If you can't find it, feel free to file a new one. In the end it will get linked up or resolved.

To change the second element in the URL, you can set <checkoutDirectoryName> in the plugin configuration.

Show
Brett Porter added a comment - I'm not sure of the issue. If you can't find it, feel free to file a new one. In the end it will get linked up or resolved. To change the second element in the URL, you can set <checkoutDirectoryName> in the plugin configuration.

People

  • Assignee:
    Brett Porter
    Reporter:
    Jerome Lacoste
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: