Maven Project Info Reports Plugin
  1. Maven Project Info Reports Plugin
  2. MPIR-130

No mark or link to SNAPSHOT artifacts in Dependency Repository Locations section of Dependencies report

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1
    • Component/s: dependencies
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Under the heading "Dependency Repository Locations". When I used the new version of MPIR on Maven One Plugin from trunk I don't get a download link for the SNAPSHOT dependency org.apache.maven.shared:maven-model-converter:jar:2.3-SNAPSHOT even though there is a column for the "apache.snapshots" repo.

      1. MPIR-130.diff
        1 kB
        Vincent Siveton
      2. MPIR-130.patch
        5 kB
        Dennis Lundberg

        Activity

        Hide
        Dennis Lundberg added a comment -

        Here's a proposed patch that works for the case with Maven One Plugin.

        This patch completely removes getDependencyUrlFromRepository(). I'm not sure why that method was needed, but it doesn't seem to be necessary. The method was added by Vincent, so I'd appreciate if he would have a look at this patch before I apply it.

        Show
        Dennis Lundberg added a comment - Here's a proposed patch that works for the case with Maven One Plugin. This patch completely removes getDependencyUrlFromRepository(). I'm not sure why that method was needed, but it doesn't seem to be necessary. The method was added by Vincent, so I'd appreciate if he would have a look at this patch before I apply it.
        Hide
        Vincent Siveton added a comment -

        I tried your patch and it works fine for maven-model-converter.
        Unfortunately, if you tried to use a snapshot like p-u:1.5.2-SNAPSHOT from snapshots.repository.codehaus.org, it fails again to add a link in the codehaus.snapshots cell.

        Show
        Vincent Siveton added a comment - I tried your patch and it works fine for maven-model-converter. Unfortunately, if you tried to use a snapshot like p-u:1.5.2-SNAPSHOT from snapshots.repository.codehaus.org, it fails again to add a link in the codehaus.snapshots cell.
        Hide
        Dennis Lundberg added a comment -

        Yes, I get that too and also this warning message on the console:

        [WARNING] The repository url 'http://snapshots.maven.codehaus.org/maven2' is invalid - Repository 'snapshots' will be blacklisted.

        Do you get that as well?

        I don't know where that repo is coming from though.

        Show
        Dennis Lundberg added a comment - Yes, I get that too and also this warning message on the console: [WARNING] The repository url 'http://snapshots.maven.codehaus.org/maven2' is invalid - Repository 'snapshots' will be blacklisted. Do you get that as well? I don't know where that repo is coming from though.
        Hide
        Vincent Siveton added a comment -

        I fixed it in r678720, snapshot deployed.
        Sounds good for several plugins. Could you double check?

        Show
        Vincent Siveton added a comment - I fixed it in r678720 , snapshot deployed. Sounds good for several plugins. Could you double check?
        Hide
        Dennis Lundberg added a comment -

        I can confirm that your patch works for both my use case and yours.

        Show
        Dennis Lundberg added a comment - I can confirm that your patch works for both my use case and yours.

          People

          • Assignee:
            Vincent Siveton
            Reporter:
            Dennis Lundberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: