Active profiles repeated each time for all projects in reactor

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None

Description

Running the active-profiles goal in a multi-module project (with subsequently more than one project in the reactor) will all the active profiles for all the projects in the reactor, repeating this for every single project that is built, resulting in exhaustive output.

Given that each showing of active profiles of a single project costs about eight lines in output (including some whitelines; that's with only one profile active), and us (over here) having 73 projects in the reactor, that's (73-1)*(73-1)*8 output lines being wasted. That's a silly 41472 lines for a simple "mvn install". Well, I suppose an even simpler "mvn clean" will do the same

And now I'm not even getting started about the fact that these 73 projects all share the same profile that they get from their top parent project.

Over here we have a custom maven-help-plugin version running that shows the active profiles of every project in the reactor only once. I made the assumption that profiles are not going to change during the coarse of a single Maven execution.

Is this a patch that we would be generally interested in?

Or is this perhaps a bug in the <inheritence> behaviour of the plugin?

  1. File
    MPH-45.diff
    24/Mar/10 12:17 AM
    1 kB
    Sander Verhagen

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

sounds a good addon.
Perhaps add in your patch a filter parameter (like a boolean) to display or not the full output.

Show
Vincent Siveton added a comment - sounds a good addon. Perhaps add in your patch a filter parameter (like a boolean) to display or not the full output.
Hide
Permalink
Brett Porter added a comment -

are you binding the active-profiles goal into the lifecycle? That's not really what it was intended for.

As for the repetition - modules may have different profiles, which is why they are listed separately. But perhaps it could just list the differences instead.

Show
Brett Porter added a comment - are you binding the active-profiles goal into the lifecycle? That's not really what it was intended for. As for the repetition - modules may have different profiles, which is why they are listed separately. But perhaps it could just list the differences instead.
Hide
Permalink
Sander Verhagen added a comment -

Well, 1,5 years later I have to dig deep into my memory. I think the following was the case.

Not just each of the projects would show its profiles, instead each of the projects would again show the profiles for each of the projects, which is definitely overkill.

This is the configuration that we're using:

<plugin>
<!-- Nicely show the active profiles during execution -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-help-plugin</artifactId>
<version>2.0.2.2-WPS</version>
<executions>
<execution>
<phase>validate</phase>
<goals>
<goal>active-profiles</goal>
</goals>
</execution>
</executions>
</plugin>

Is this not what it is meant for? Not understanding why you say that.

Show
Sander Verhagen added a comment - Well, 1,5 years later I have to dig deep into my memory. I think the following was the case. Not just each of the projects would show its profiles, instead each of the projects would again show the profiles for each of the projects, which is definitely overkill. This is the configuration that we're using: <plugin> <!-- Nicely show the active profiles during execution --> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-help-plugin</artifactId> <version>2.0.2.2-WPS</version> <executions> <execution> <phase>validate</phase> <goals> <goal>active-profiles</goal> </goals> </execution> </executions> </plugin> Is this not what it is meant for? Not understanding why you say that.
Hide
Permalink
Brett Porter added a comment -

no, it's typically run from the command line.

We'll have to take a closer look at this - but it sounds like you've prepared a patch internally. Would you like to attach it here for us to consider applying?

Show
Brett Porter added a comment - no, it's typically run from the command line. We'll have to take a closer look at this - but it sounds like you've prepared a patch internally. Would you like to attach it here for us to consider applying?
Hide
Permalink
Sander Verhagen added a comment -

Funny, I don't see the purpose at all for running it on the command-line... how different needs can be, 'ey...

I'll attach a patch in a minute. It's just very stupid, straightforward.

Show
Sander Verhagen added a comment - Funny, I don't see the purpose at all for running it on the command-line... how different needs can be, 'ey... I'll attach a patch in a minute. It's just very stupid, straightforward.

People

  • Assignee:
    Unassigned
    Reporter:
    Sander Verhagen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: