Maven 2.x Help Plugin

Hide passwords for effective-settings

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0.2
  • Fix Version/s: 2.1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Actually all passwords (server and proxy) are displayed. We should hide them by default.

Issue Links

is related to

Wish - General wishlist item MPH-86 Hide passwords for effective-pom

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

fixed in r682328

Show
Vincent Siveton added a comment - fixed in r682328
Hide
Permalink
Rob Juurlink added a comment - - edited

When help:effective-settings is active, the password is internally truncated also. Looking at the deploy module, it tries to login with the password "***", and so the deploy fails:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.5:deploy (default-deploy) on project fwg: Failed to deploy artifacts: Could not transfer artifact nl.fwg:fwg:pom:3.09.031 from/to releases (http://xxx/nexus/content/repositories/releases): Access denied to: http://xxx/nexus/content/repositories/releases/nl/fwg/fwg/3.09.031/fwg-3.09.031.pom -> [Help 1]

Logged with tcpdump, the Authorization header is:
Authorization: Basic dGVzdDoqKio=

Which decodes to "test:***"

maven-help-plugin, version: 2.1.1
maven, version 3.0.4

Show
Rob Juurlink added a comment - - edited When help:effective-settings is active, the password is internally truncated also. Looking at the deploy module, it tries to login with the password "***", and so the deploy fails: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.5:deploy (default-deploy) on project fwg: Failed to deploy artifacts: Could not transfer artifact nl.fwg:fwg:pom:3.09.031 from/to releases ( http://xxx/nexus/content/repositories/releases): Access denied to: http://xxx/nexus/content/repositories/releases/nl/fwg/fwg/3.09.031/fwg-3.09.031.pom -> [Help 1] Logged with tcpdump, the Authorization header is: Authorization: Basic dGVzdDoqKio= Which decodes to "test:***" maven-help-plugin, version: 2.1.1 maven, version 3.0.4

People

  • Assignee:
    Vincent Siveton
    Reporter:
    Vincent Siveton
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: