Issue Details (XML | Word | Printable)

Key: MPH-42
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Vincent Siveton
Reporter: Sander Verhagen
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven 2.x Help Plugin

Active profiles recursively growing

Created: 02/Aug/08 08:15 PM   Updated: 03/Aug/08 09:45 AM   Resolved: 03/Aug/08 09:45 AM
Return to search
Component/s: None
Affects Version/s: 2.0.2, 2.1
Fix Version/s: 2.1

Time Tracking:
Not Specified

File Attachments: 1. Text File Active-profiles-recursively-growing.diff.txt (1 kB)


Patch Submitted: Yes


 Description  « Hide

Running the active-profiles goal in a project where parents introduce profiles, any sub-modules of these parents will report a number of duplicates of these profiles that grows each time the goal is invoked.

This is caused by the plugin (recursively) retrieving profiles from subsequent parents, and adding them to the project on which the goal is invoked. The plugin means to add the profiles that it finds so that it can give an aggregated listing of profiles over the full inheritance tree of the project on which the goal is invoked (which is okay), it is mistaken in actually adding them to the project on which the goal is invoked. It changes the project on which the goal is invoked, rather than merely observing it. Because the plugin keeps on adding the same profiles from parent projects, every time it is invoked, to the same project on which the goal is invoked, the aggregated listing keeps on growing and growing during execution.

Rated this Critical since on large projects this renders the plugin useless; the output will become booming; well, you know how that goes with recursion.

Fix is attached as unified diff.



Vincent Siveton added a comment - 03/Aug/08 09:45 AM

Patch applied in r682181, snapshot deployed. Thanks!


Vincent Siveton made changes - 03/Aug/08 09:45 AM
Field Original Value New Value
Assignee Vincent Siveton [ siveton ]
Resolution Fixed [ 1 ]
Fix Version/s 2.1 [ 12300 ]
Status Open [ 1 ] Closed [ 6 ]