Maven Help Plugin
  1. Maven Help Plugin
  2. MPH-40

help:effective-pom emits invalid XML to output file

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Currently, this fragile post-processing is needed to make the content in a file generated with -Doutput=... parseable:

      <move overwrite="true" file="$

      {deploy.effective.pom.xml.file}.tmp" tofile="${deploy.effective.pom.xml.file}

      ">
      <filterchain>
      <replaceregex pattern="^(Created by" replace='<!-- \1' />
      <replaceregex pattern="^<.xml .*>(<project>)" replace='--> \1' />
      <replaceregex pattern="^*+$" replace='' />
      </filterchain>
      </move>

      Solution: Either add XML comments in the generation markup, or only output the XML proper to the output file, leaving the text out of it.

        Issue Links

          Activity

          Hide
          Vincent Siveton added a comment -

          We could make xml comments only if reactorProjects is empty.
          If reactorProjects is not empty, the output file appends all effective poms in one file and thus it is an invalid xml file.

          Show
          Vincent Siveton added a comment - We could make xml comments only if reactorProjects is empty. If reactorProjects is not empty, the output file appends all effective poms in one file and thus it is an invalid xml file.
          Hide
          Jürgen Hermann added a comment -

          > We could make xml comments only if reactorProjects is empty.
          Well, that'd help for a certain number of cases.

          > If reactorProjects is not empty, the output file appends all effective poms in one file and thus it is an invalid xml file.
          That can be solved by adding an outer root element around the POMs, which then allows to select the needed POMs by standard tools (XPath) instead of trickery that'll likely break in later releases. It certainly doesn't make automatic processing any harder, just the opposite.

          Show
          Jürgen Hermann added a comment - > We could make xml comments only if reactorProjects is empty. Well, that'd help for a certain number of cases. > If reactorProjects is not empty, the output file appends all effective poms in one file and thus it is an invalid xml file. That can be solved by adding an outer root element around the POMs, which then allows to select the needed POMs by standard tools (XPath) instead of trickery that'll likely break in later releases. It certainly doesn't make automatic processing any harder, just the opposite.
          Hide
          Vincent Siveton added a comment -

          Fixed in r688412, snapshot deployed.

          For reactorProjects, I added a <projects/> tag as suggested.

          Show
          Vincent Siveton added a comment - Fixed in r688412 , snapshot deployed. For reactorProjects, I added a <projects/> tag as suggested.

            People

            • Assignee:
              Vincent Siveton
              Reporter:
              Jürgen Hermann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: