Maven 1.x FAQ Plugin

Faq plugin 1.6 does not work with upgraded dependencies for Maven-1.1-beta-3

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.6.1
  • Component/s: None
  • Description:
    Hide

    After our various dependency upgrades (jelly, dom4j, jaxen, xerces...), the faq plugin 1.6 does not process fml files correctly if they contain more than one <part> section. Not sure what exactly causes it, but it gets fixed by using a 'var' parameter in the x:forEach loop over different parts.

    Show
    After our various dependency upgrades (jelly, dom4j, jaxen, xerces...), the faq plugin 1.6 does not process fml files correctly if they contain more than one <part> section. Not sure what exactly causes it, but it gets fixed by using a 'var' parameter in the x:forEach loop over different parts.

Activity

Hide
Arnaud Heritier added a comment - 24/Jul/06 3:32 PM

I found the following usages of x:forEach without a var attribute :

plugins\changes\src\plugin-resources\changes.jsl(37): <x:forEach select="head/*">
plugins\changes\src\plugin-resources\changes.jsl(55): <x:forEach select="release">
plugins\changes\target\classes\plugin-resources\changes2rss.jsl(55): <x:forEach var="action" select="//release[@version='${pom.currentVersion}']/action">
plugins\checkstyle\src\plugin-resources\checkstyle-summary.jsl(32): <x:forEach select="//error" sort="@message">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(86): <x:forEach select="//error[@severity='error']" sort="@count" descending="true">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(101): <x:forEach select="//error[@severity='warning']" sort="@count" descending="true">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(116): <x:forEach select="//error[@severity='info']" sort="@count" descending="true">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(89): <x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(101): <x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(116): <x:forEach select="tag" sort="@name">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(141): <x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(143): <x:forEach select="tag" var="tag" sort="@name">

Do you think that we have to fix them ?
All others x:forEach have this attribute.

And I found in several plugins the comment :
<!-- x:forEach is busted -->

Show
Arnaud Heritier added a comment - 24/Jul/06 3:32 PM I found the following usages of x:forEach without a var attribute : plugins\changes\src\plugin-resources\changes.jsl(37): <x:forEach select="head/*"> plugins\changes\src\plugin-resources\changes.jsl(55): <x:forEach select="release"> plugins\changes\target\classes\plugin-resources\changes2rss.jsl(55): <x:forEach var="action" select="//release[@version='${pom.currentVersion}']/action"> plugins\checkstyle\src\plugin-resources\checkstyle-summary.jsl(32): <x:forEach select="//error" sort="@message"> plugins\checkstyle\src\plugin-resources\checkstyle.jsl(86): <x:forEach select="//error[@severity='error']" sort="@count" descending="true"> plugins\checkstyle\src\plugin-resources\checkstyle.jsl(101): <x:forEach select="//error[@severity='warning']" sort="@count" descending="true"> plugins\checkstyle\src\plugin-resources\checkstyle.jsl(116): <x:forEach select="//error[@severity='info']" sort="@count" descending="true"> plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(89): <x:forEach select="$libraries" sort="@uri"> plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(101): <x:forEach select="$libraries" sort="@uri"> plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(116): <x:forEach select="tag" sort="@name"> plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(141): <x:forEach select="$libraries" sort="@uri"> plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(143): <x:forEach select="tag" var="tag" sort="@name"> Do you think that we have to fix them ? All others x:forEach have this attribute. And I found in several plugins the comment : <!-- x:forEach is busted -->
Hide
Lukas Theussl added a comment - 24/Jul/06 3:43 PM

Yes, I'm aware of that. But AFAICT, the faq plugin is the only one where this leads to problems. I'm not sure about the cause, maybe it's because there is a nested forEach here, or because in all other cases, there is only one iteration. I have checked all the plugins above and haven't found a similar problem. No guarantees though...

Show
Lukas Theussl added a comment - 24/Jul/06 3:43 PM Yes, I'm aware of that. But AFAICT, the faq plugin is the only one where this leads to problems. I'm not sure about the cause, maybe it's because there is a nested forEach here, or because in all other cases, there is only one iteration. I have checked all the plugins above and haven't found a similar problem. No guarantees though...

People

Dates

  • Created:
    24/Jul/06 1:58 PM
    Updated:
    24/Jul/06 3:43 PM
    Resolved:
    24/Jul/06 2:50 PM