Issue Details (XML | Word | Printable)

Key: MPECLIPSE-69
Type: Improvement Improvement
Status: Open Open
Priority: Major Major
Assignee: Unassigned
Reporter: Chad Woolley
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Eclipse Plugin

Make plugin work better "out of the box"

Created: 01/Feb/05 02:21 AM   Updated: 26/Nov/05 09:28 AM
Return to search
Component/s: None
Affects Version/s: 1.9
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. Text File maven_eclipse_plugin_patch.txt (2 kB)



 Description  « Hide

Hi,

Attached is a patch which makes the following changes to the eclipse:external-tools-21 goal:

1. Makes default action to run goal against project.xml in the current project.
2. Makes default to refresh project containing the selected resource
3. Removes code to add each entry to favorites list, because they fill up the list and makes user have to scroll to see the bottom of the external tools menu.

I think these would be much more intuitive and convenient defaults for the majority of the plugin users.

Thanks,
Chad

Index: eclipse/src/plugin-resources/templates/launch.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/eclipse/src/plugin-resources/templates/launch.jelly,v
retrieving revision 1.4
diff -u -r1.4 launch.jelly
— eclipse/src/plugin-resources/templates/launch.jelly 4 Mar 2004 18:04:37 -0000 1.4
+++ eclipse/src/plugin-resources/templates/launch.jelly 1 Feb 2005 06:55:58 -0000
@@ -19,13 +19,17 @@

<launchConfiguration type="org.eclipse.ui.externaltools.ProgramLaunchConfigurationType">
<stringAttribute

  • key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-e -p $${resource_name} ${goal}"/>
    + key="org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS" value="-e -p project.xml ${goal}"/>
    <stringAttribute
    key="org.eclipse.ui.externaltools.ATTR_REFRESH_SCOPE" value="$${project}"/>
    + <stringAttribute
    + key="org.eclipse.debug.core.ATTR_REFRESH_SCOPE" value="$${project}"/>
    + <!-- don't add favorites, they overfill the menu
    <listAttribute key="org.eclipse.debug.ui.favoriteGroups">
    <listEntry value="org.eclipse.ui.externaltools.launchGroup"/>
    </listAttribute>
    + -->
    <stringAttribute
  • key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="$${container_loc}"/>
    + key="org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY" value="$${project_loc}"/>
    <stringAttribute key="org.eclipse.ui.externaltools.ATTR_LOCATION" value="${tool.loc}"/>
    </launchConfiguration>


Chad Woolley made changes - 01/Feb/05 02:21 AM
Field Original Value New Value
Attachment maven_eclipse_plugin_patch.txt [ 13902 ]
fabrizio giustina made changes - 26/Nov/05 09:28 AM
Fix Version/s 1.9 [ 11100 ]