jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 1.x Eclipse Plugin
  • MPECLIPSE-59

Skipped dependency with eclipse.dependency false

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: 1.10
  • Labels:
    None
  • Environment:
    Java 1.4.2_04, win2k

Description

A dependency element like:

<eclipse.dependency>true</eclipse.dependency>

in project.xml causes maven eclipse to skip the dependency completely,
rather than reverting to simple .classpath entry.

I have maven-eclipse-plugin-1.9.jar and maven v. 1.0.1

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Wesley Vrieselaar added a comment - 01/Mar/05 5:33 AM

I would expect eclipse.plugin=false to behave af if the eclipse.plugin property wasn't set at all. Chances are I'm wrong about this, but I couldn't find any documentation that contradicts me.

When I trace it back to the source code, it's this 'when' in classpath.jelly that makes it skip the dependency entirely:

<j:when test="${eclipseDependency == 'false'}">-->
<!-- ignore specific dependencies -->
</j:when>

Again, I'm not too sure it should be doing this. When I take these lines out the dependency is treated as if eclipse.dependency isn't set at all: <classpathentry kind="var" in .classpath and <projects> in .project is empty.

Show
Wesley Vrieselaar added a comment - 01/Mar/05 5:33 AM I would expect eclipse.plugin=false to behave af if the eclipse.plugin property wasn't set at all. Chances are I'm wrong about this, but I couldn't find any documentation that contradicts me. When I trace it back to the source code, it's this 'when' in classpath.jelly that makes it skip the dependency entirely: <j:when test="${eclipseDependency == 'false'}">--> <!-- ignore specific dependencies --> </j:when> Again, I'm not too sure it should be doing this. When I take these lines out the dependency is treated as if eclipse.dependency isn't set at all: <classpathentry kind="var" in .classpath and <projects> in .project is empty.
Hide
Permalink
Brett Porter added a comment - 03/Mar/05 7:14 PM

(Eric Pugh)
I think the idea of eclipse.dependency is to filter out completely those dependencies.. The options are true/false, and default to true. So, if the eclipse.dependency is skipped, that is the same as true.

It is possible we need to have something more like:
eclipse.dependencyType that specifies what something is...

Eric

Show
Brett Porter added a comment - 03/Mar/05 7:14 PM (Eric Pugh) I think the idea of eclipse.dependency is to filter out completely those dependencies.. The options are true/false, and default to true. So, if the eclipse.dependency is skipped, that is the same as true. It is possible we need to have something more like: eclipse.dependencyType that specifies what something is... Eric
Hide
Permalink
fabrizio giustina added a comment - 27/Nov/05 4:38 PM

I can't see any valid use case why the eclipse project should not contain dependencies needed when building using maven.
Closing as a won't fix, please reopen the bug if you think this could be needed and post a valid use case.

Show
fabrizio giustina added a comment - 27/Nov/05 4:38 PM I can't see any valid use case why the eclipse project should not contain dependencies needed when building using maven. Closing as a won't fix, please reopen the bug if you think this could be needed and post a valid use case.

People

  • Assignee:
    fabrizio giustina
    Reporter:
    Henri Bonnehuit
Vote (0)
Watch (0)

Dates

  • Created:
    29/Nov/04 8:00 AM
    Updated:
    27/Nov/05 4:38 PM
    Resolved:
    27/Nov/05 4:38 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.