Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.7
    • Fix Version/s: 1.9
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Basically, its seems that the emphasis should be on making the eclipse stuff not overwrite, but modify the exisiting files, so I used the cruisecontrol plugin as the basis for what I'm trying to achieve. Not overly happy using jsl to fix it (I'd prefer a more POJO approach and less script), but at the moment it'll clear up a lot of the problems.

      This issue will initially fix the .project file generation. If it looks ok to people, I'll work on the .classpath file and submit that shortly too.

      This will allow us to close a number of other issues against the plugin.

      1. patch.txt
        5 kB
        Kristopher Brown
      2. patch2.txt
        19 kB
        Kristopher Brown

        Activity

        Hide
        Kristopher Brown added a comment -

        Patch to modify:
        plugin.jelly
        project.xml
        Also adds:
        src/plugin-resources/project.jsl

        The .project template can be removed also at a later point.

        Show
        Kristopher Brown added a comment - Patch to modify: plugin.jelly project.xml Also adds: src/plugin-resources/project.jsl The .project template can be removed also at a later point.
        Hide
        Kristopher Brown added a comment -

        This patch superceeds the previous. The patch is against version 1.7 and Maven RC3, so is up to date at posting time. Please note that this contains a number of fixes/enhancements.

        • junit is added if you state it is a dependancy and don't have a test directory. This allows you to extend JUnit in a project. MPECLIPSE-6.
        • maven.eclipse.classpath.include handling moved outside of the if statement that only considers it is tests are present. MPECLIPSE-17
        • added clean goal to delete .project and .classpath files.
        • Rewritten the templates so that they work via jsl, allowing them to update previous versions. Currently the project file is preserved and the classpath file is mainly overwritten. In this form, the classpath file can be changed overtime to allow it update more rather than overwrite.
        • added a new feature to analyse the workspace and create workspace dependancies if they are open projects in the defined workspace. This is only activated if turned on via the mave.eclipse.workspace.analyse property, and therefore will not interfere with things unless you choose to use it. I think this is a better alternative to the eclipse.dependancy feature and supports the individual developer better than having to state in the pom that you have a local dependancy.

        Other Points I've noticed looking through the big list:

        • MPECLIPSE-25 is a suitable fix for MPECLIPSE1 and MPELCIPSE-12. Can we close these therfore?
        • MPECLIPSE-7 is no longer an issue afaik. Can we close this?
        • MPECLIPSE-9 and MPECLIPSE-10 are almost the same - duplicate? Can we close one of them?
        Show
        Kristopher Brown added a comment - This patch superceeds the previous. The patch is against version 1.7 and Maven RC3, so is up to date at posting time. Please note that this contains a number of fixes/enhancements. junit is added if you state it is a dependancy and don't have a test directory. This allows you to extend JUnit in a project. MPECLIPSE-6 . maven.eclipse.classpath.include handling moved outside of the if statement that only considers it is tests are present. MPECLIPSE-17 added clean goal to delete .project and .classpath files. Rewritten the templates so that they work via jsl, allowing them to update previous versions. Currently the project file is preserved and the classpath file is mainly overwritten. In this form, the classpath file can be changed overtime to allow it update more rather than overwrite. added a new feature to analyse the workspace and create workspace dependancies if they are open projects in the defined workspace. This is only activated if turned on via the mave.eclipse.workspace.analyse property, and therefore will not interfere with things unless you choose to use it. I think this is a better alternative to the eclipse.dependancy feature and supports the individual developer better than having to state in the pom that you have a local dependancy. Other Points I've noticed looking through the big list: MPECLIPSE-25 is a suitable fix for MPECLIPSE1 and MPELCIPSE-12. Can we close these therfore? MPECLIPSE-7 is no longer an issue afaik. Can we close this? MPECLIPSE-9 and MPECLIPSE-10 are almost the same - duplicate? Can we close one of them?
        Hide
        Kristopher Brown added a comment -

        Correction:

        Show
        Kristopher Brown added a comment - Correction: MPECLIPSE-25 is a suitable fix for MPECLIPSE-1 and MPECLIPSE-12 . Can we close these therfore?
        Hide
        Kristopher Brown added a comment -

        After patching, also remove classpath.jelly and project.jelly from the templates directory as these are no longer used.

        Show
        Kristopher Brown added a comment - After patching, also remove classpath.jelly and project.jelly from the templates directory as these are no longer used.
        Hide
        David Eric Pugh added a comment -

        I have grabbed the eclipse:clean goal, and will commit it. Good bit of code.. could be using it in lots of places including the unit tests!

        As far as the rest of it, I think you are on the right track here. However, can you submit a fresh patch against the latest and greatest? And maybe start up some discussion on maven-dev? I'd like to keep the same basic pattern that we ahve now of the .classpath and .project files being generated by seperate templates.

        Show
        David Eric Pugh added a comment - I have grabbed the eclipse:clean goal, and will commit it. Good bit of code.. could be using it in lots of places including the unit tests! As far as the rest of it, I think you are on the right track here. However, can you submit a fresh patch against the latest and greatest? And maybe start up some discussion on maven-dev? I'd like to keep the same basic pattern that we ahve now of the .classpath and .project files being generated by seperate templates.
        Hide
        Kristopher Brown added a comment -

        I suggest this issue is just closed, it seems that most parts of the .project and .classpath files are now catered for in the plugin and therefore the concept is no longer valid. Any new features I'll add as separate issues.

        Show
        Kristopher Brown added a comment - I suggest this issue is just closed, it seems that most parts of the .project and .classpath files are now catered for in the plugin and therefore the concept is no longer valid. Any new features I'll add as separate issues.
        Hide
        Kristopher Brown added a comment -

        Resolving as "won't fix" as I think the concept is no longer valid in light of recent changes

        Show
        Kristopher Brown added a comment - Resolving as "won't fix" as I think the concept is no longer valid in light of recent changes

          People

          • Assignee:
            Unassigned
            Reporter:
            Kristopher Brown
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 1 day
              1d
              Logged:
              Time Spent - Not Specified
              Not Specified