maven-eclipse-plugin does not generate all artifacts one could expect

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Cannot Reproduce
  • Affects Version/s: None
  • Fix Version/s: 1.8
  • Labels:
    None

Description

eclipse plugin doesnot generate all expected artifacts. for instance :

  • if build/aspectSourceDirectory is present in the pom, a source folder corresponding to this source directory should be added to the project AND aspectj nature should be attached to the eclipse project (assuming aspectj plugin has been installed)
  • if build/resource(s) are declared in the pom, a source folder should be created in the eclipse project for every unique resource folder. same goes for unitTest/resources (and perhaps integrationUnitTest ? never used it so im not sure of whats declared in the pom)
  1. Text File
    maveneclipse.patch
    18/Jan/04 5:03 PM
    3 kB
    Martin van den Bemt
  2. File
    plugin.jelly
    28/Jul/03 3:21 PM
    20 kB
    gilles dodinet
  3. XML File
    project.xml
    28/Jul/03 3:22 PM
    3 kB
    gilles dodinet

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
gilles dodinet added a comment -

also maven-eclipse-plugin doesnt seem to support jar overriding, thus writing inconsistent .classpath file ("missing required library")

Show
gilles dodinet added a comment - also maven-eclipse-plugin doesnt seem to support jar overriding, thus writing inconsistent .classpath file ("missing required library")
Hide
Permalink
gilles dodinet added a comment -

completly rewritten maven-eclipse-plugin using taglib.
o classpathentry/@excluding support
o classpathentry/@output support (unitTestSourceDirectory only)
o use JRE_CONTAINER instead of JRE_LIB
o jar overriding support
o build.resources and build.unitTest.resources support
optional (using a property) :
o add aspectj nature to project
.project is NOT generated but rather transformed using jelly:xml taglib and java | aspectj natures are added only if not already present.

Show
gilles dodinet added a comment - completly rewritten maven-eclipse-plugin using taglib. o classpathentry/@excluding support o classpathentry/@output support (unitTestSourceDirectory only) o use JRE_CONTAINER instead of JRE_LIB o jar overriding support o build.resources and build.unitTest.resources support optional (using a property) : o add aspectj nature to project .project is NOT generated but rather transformed using jelly:xml taglib and java | aspectj natures are added only if not already present.
Hide
Permalink
gilles dodinet added a comment -

added following dependencies :
o commons-jelly-tags-log
o commons-jelly-tags-util
o commons-jelly-tags-xml
o commons-jelly-tags-junit
o commons-logging

Show
gilles dodinet added a comment - added following dependencies : o commons-jelly-tags-log o commons-jelly-tags-util o commons-jelly-tags-xml o commons-jelly-tags-junit o commons-logging
Hide
Permalink
Ben Walding added a comment -

You want the bad news?

I refactored this yesterday, so those patches won't apply.

Basically ripped the .classpath xml out into classpath.jelly and the .project xml into project.jelly

Should be trivial to fix the patch, but if you want it done sooner rather than later, then you'll have to resubmit. (i.e. I'll eventually get around to it, but it'll be a lot quicker if you do it!)

Show
Ben Walding added a comment - You want the bad news? I refactored this yesterday, so those patches won't apply. Basically ripped the .classpath xml out into classpath.jelly and the .project xml into project.jelly Should be trivial to fix the patch, but if you want it done sooner rather than later, then you'll have to resubmit. (i.e. I'll eventually get around to it, but it'll be a lot quicker if you do it!)
Hide
Permalink
Martin van den Bemt added a comment -

This patch adds maven.jar.override support to the eclipse plugin.
Ben can you apply it ?

Show
Martin van den Bemt added a comment - This patch adds maven.jar.override support to the eclipse plugin. Ben can you apply it ?
Hide
Permalink
Martin van den Bemt added a comment -

MPECLIPSE-6 is also fixed when you apply this patch

Show
Martin van den Bemt added a comment - MPECLIPSE-6 is also fixed when you apply this patch
Hide
Permalink
David Eric Pugh added a comment -

Hi.. I don't see this issue.. I have depedencies on jars for MSSQL server like msbase.jar and they come through fine. If this is an issue, it seems like maven should deal with the override versus version so that it always gives us a good path...

Show
David Eric Pugh added a comment - Hi.. I don't see this issue.. I have depedencies on jars for MSSQL server like msbase.jar and they come through fine. If this is an issue, it seems like maven should deal with the override versus version so that it always gives us a good path...
Hide
Permalink
Andreas Guther added a comment -

I am missing the additional aspectSourceDirectory generated classpath entry as well.

It seems that the classpath entry could be manually configured via the maven.eclipse.classpath.include property. However, it would be nice to have that generated automatically once the aspectSourceDirectory entry is present and has a value without the need to add it to the properties.

From reading the issue history I have the impression that the problem cannot be reproduced. This should be easy by just following the steps described at http://maven.apache.org/reference/plugins/aspectj/.

The following entry needs to be added to the project.xml:

<build>
<sourceDirectory>src/java</sourceDirectory>
<aspectSourceDirectory>src/aspectj</aspectSourceDirectory>
</build>

This should result in an additional entry in the .classpath file.

Show
Andreas Guther added a comment - I am missing the additional aspectSourceDirectory generated classpath entry as well. It seems that the classpath entry could be manually configured via the maven.eclipse.classpath.include property. However, it would be nice to have that generated automatically once the aspectSourceDirectory entry is present and has a value without the need to add it to the properties. From reading the issue history I have the impression that the problem cannot be reproduced. This should be easy by just following the steps described at http://maven.apache.org/reference/plugins/aspectj/. The following entry needs to be added to the project.xml: <build> <sourceDirectory>src/java</sourceDirectory> <aspectSourceDirectory>src/aspectj</aspectSourceDirectory> </build> This should result in an additional entry in the .classpath file.

People

  • Assignee:
    Unassigned
    Reporter:
    gilles dodinet
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: