maven eclipse plug-in should support eclipse checkstyle plug-in

Here's a patch to implement this. Setting maven.eclipse.checkstyle to 'yes' in project.properties will result in the appropriate settings being added to the generated .project file.

Patch no longer applies

Revised patch made against MAVEN_RC1_STABLE branch.

I'm -1 for this modification.

a) it exists more than one checkstyle plugin for eclipse

• http://www.mvmsoft.de/content/plugins/checkclipse/checkclipse.htm
• http://eclipse-cs.sourceforge.net/
  b) we can't integrate all eclipse plugin fetures in eclipse project file.

I use checkclipse too, so maybe we can add both of them in as options.

What would you suggest as an alternative solution to this problem? The
current situation doesn't work because running 'maven eclipse' to add
new dependencies to the project classpath overwrites any other additions
to the .project and .classpath files made through the Eclipse user
interface.

-Mark.

Is the solution then to change the plugin to respect modifications made by
users? Maybe have an eclipse target that respects those modifications, and
an eclipse:clean that rebuilds it from scratch?

ERic Pugh

A better way might be for plugins to register themselves into the
eclipse plugin and be passed a DOM of the .classpath / .project. They
then manipulate this as required.

Similar to how the report plugin works.

Ben Walding

I think that the files i provided for MAVEN-525 do exactly what you
want. it defines a taglib which declares among others a tag that adds
project nature and project builder to .project using jelly:xml. perhpas
it may help.

Gilles Dodinet

I don't have time to investigate on your plugin modification, but your
addBuilder/addNature taglibs seems to be interesting.

I am marking this bug as not fixing. Instead, lets try and come up with a more generic approach to extending the .project/.classpath files.. There are some other bugs with code that has this approach. Need to start a discussion on maven-dev@ and get this fixed.