Maven 1.x Distribution Plugin
  1. Maven 1.x Distribution Plugin
  2. MPDIST-28

Allow to configure to which files should use CRLF line endings in Zip archives

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Labels:
      None
    • Environment:
      1.7
    • Number of attachments :
      1

      Description

      Add a new property to replace the hardcoded filter */.txt used in fixcrlf tasks.

        Issue Links

          Activity

          Hide
          Phil Steitz added a comment -

          I had to comment out the "assert:assertPluginAvailable groupId="maven" artifactId="maven-plugin-plugin" minRelease="1.7"

          With this in, when I tested the newly installed plugin (same happens with the currently deployed SNAPSHOT) maven dies with NPE reported at that line.

          Show
          Phil Steitz added a comment - I had to comment out the "assert:assertPluginAvailable groupId="maven" artifactId="maven-plugin-plugin" minRelease="1.7" With this in, when I tested the newly installed plugin (same happens with the currently deployed SNAPSHOT) maven dies with NPE reported at that line.
          Hide
          Phil Steitz added a comment -

          Added a patch that allows both lf and crlf filters to be specified.

          Show
          Phil Steitz added a comment - Added a patch that allows both lf and crlf filters to be specified.
          Hide
          Lukas Theussl added a comment -

          Thanks Phil!
          Just to clarify: you get the NPE with the plugin-plugin-1.7-SNAPSHOT installed? Running maven 1.0 or 1.1?
          It shouldn't be necessary to comment the assert out in any case.

          Show
          Lukas Theussl added a comment - Thanks Phil! Just to clarify: you get the NPE with the plugin-plugin-1.7-SNAPSHOT installed? Running maven 1.0 or 1.1? It shouldn't be necessary to comment the assert out in any case.
          Hide
          Arnaud Heritier added a comment -

          the nullpointer is due to the fact that you don't have the assertPluginAvailable tag in the plugin-plugin

          Show
          Arnaud Heritier added a comment - the nullpointer is due to the fact that you don't have the assertPluginAvailable tag in the plugin-plugin
          Hide
          Arnaud Heritier added a comment -

          Applied. You can download the SNAPSHOT from cvs.apache.org
          You also need to have (but I don't remember why) maven-plugin-plugin v1.7-SNAPSHOT and maven-artifact-plugin v1.3-SNAPSHOT

          Show
          Arnaud Heritier added a comment - Applied. You can download the SNAPSHOT from cvs.apache.org You also need to have (but I don't remember why) maven-plugin-plugin v1.7-SNAPSHOT and maven-artifact-plugin v1.3-SNAPSHOT
          Hide
          Phil Steitz added a comment -

          Thanks and sorry to take so long to verify and respond.

          I can now compile and install current svn head fine under maven 1.0.2 with maven-plugin-plugin 1.6 and maven-artifact-plugin 1.5.2. If I try to install and use plugin-plugin 1.7, this requires artifact 1.7 which requires maven 1.1.

          Show
          Phil Steitz added a comment - Thanks and sorry to take so long to verify and respond. I can now compile and install current svn head fine under maven 1.0.2 with maven-plugin-plugin 1.6 and maven-artifact-plugin 1.5.2. If I try to install and use plugin-plugin 1.7, this requires artifact 1.7 which requires maven 1.1.

            People

            • Assignee:
              Arnaud Heritier
              Reporter:
              Arnaud Heritier
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: