Maven 1.x Distribution Plugin

Allow to configure to which files should use CRLF line endings in Zip archives

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7
  • Fix Version/s: 1.7
  • Component/s: None
  • Labels:
    None
  • Environment:
    1.7
  • Number of attachments :
    1

Description

Add a new property to replace the hardcoded filter */.txt used in fixcrlf tasks.

Issue Links

This issue supercedes:
MPDIST-9 Add "fixcrlf" step Minor Closed
This issue depends upon:
MPDIST-27 Zip archives should use CRLF line endings on txt files Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Phil Steitz added a comment -

I had to comment out the "assert:assertPluginAvailable groupId="maven" artifactId="maven-plugin-plugin" minRelease="1.7"

With this in, when I tested the newly installed plugin (same happens with the currently deployed SNAPSHOT) maven dies with NPE reported at that line.

Show
Phil Steitz added a comment - I had to comment out the "assert:assertPluginAvailable groupId="maven" artifactId="maven-plugin-plugin" minRelease="1.7" With this in, when I tested the newly installed plugin (same happens with the currently deployed SNAPSHOT) maven dies with NPE reported at that line.
Hide
Permalink
Phil Steitz added a comment -

Added a patch that allows both lf and crlf filters to be specified.

Show
Phil Steitz added a comment - Added a patch that allows both lf and crlf filters to be specified.
Hide
Permalink
Lukas Theussl added a comment -

Thanks Phil!
Just to clarify: you get the NPE with the plugin-plugin-1.7-SNAPSHOT installed? Running maven 1.0 or 1.1?
It shouldn't be necessary to comment the assert out in any case.

Show
Lukas Theussl added a comment - Thanks Phil! Just to clarify: you get the NPE with the plugin-plugin-1.7-SNAPSHOT installed? Running maven 1.0 or 1.1? It shouldn't be necessary to comment the assert out in any case.
Hide
Permalink
Arnaud Heritier added a comment -

the nullpointer is due to the fact that you don't have the assertPluginAvailable tag in the plugin-plugin

Show
Arnaud Heritier added a comment - the nullpointer is due to the fact that you don't have the assertPluginAvailable tag in the plugin-plugin
Hide
Permalink
Arnaud Heritier added a comment -

Applied. You can download the SNAPSHOT from cvs.apache.org
You also need to have (but I don't remember why) maven-plugin-plugin v1.7-SNAPSHOT and maven-artifact-plugin v1.3-SNAPSHOT

Show
Arnaud Heritier added a comment - Applied. You can download the SNAPSHOT from cvs.apache.org You also need to have (but I don't remember why) maven-plugin-plugin v1.7-SNAPSHOT and maven-artifact-plugin v1.3-SNAPSHOT
Hide
Permalink
Phil Steitz added a comment -

Thanks and sorry to take so long to verify and respond.

I can now compile and install current svn head fine under maven 1.0.2 with maven-plugin-plugin 1.6 and maven-artifact-plugin 1.5.2. If I try to install and use plugin-plugin 1.7, this requires artifact 1.7 which requires maven 1.1.

Show
Phil Steitz added a comment - Thanks and sorry to take so long to verify and respond. I can now compile and install current svn head fine under maven 1.0.2 with maven-plugin-plugin 1.6 and maven-artifact-plugin 1.5.2. If I try to install and use plugin-plugin 1.7, this requires artifact 1.7 which requires maven 1.1.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.