Maven 1.x Dashboard Plugin

Change location of checkstyle files after releasing checkstyle plugin 3.0

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.9
  • Fix Version/s: 1.9
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The location of the checkstyle files changes in 3.0 version of the plugin, so update the dashboard properties accordingly

Index: plugin.properties
===================================================================
— plugin.properties (revision 295118)
+++ plugin.properties (working copy)
@@ -96,7 +96,7 @@

  1. Properties for the Checkstyle files aggregator
    maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
    -maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csfiles.label = CS Files
    maven.dashboard.aggregator.csfiles.goal = checkstyle
    maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
    @@ -104,7 +104,7 @@

    # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
    maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
    -maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csall.label = CS err/warn
    maven.dashboard.aggregator.csall.goal = checkstyle
    maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
    @@ -112,7 +112,7 @@
  1. Properties for the Checkstyle error aggregator (only errors)
    maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
    -maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cserrors.label = CS errors
    maven.dashboard.aggregator.cserrors.goal = checkstyle
    maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
    @@ -120,7 +120,7 @@

    # Properties for the Checkstyle warning aggregator (only warnings)
    maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
    -maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cswarnings.label = CS warnings
    maven.dashboard.aggregator.cswarnings.goal = checkstyle
    maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings

Index: xdocs/properties.xml
===================================================================
— xdocs/properties.xml (revision 295118)
+++ xdocs/properties.xml (working copy)
@@ -101,7 +101,7 @@

  1. Properties for the Checkstyle files aggregator
    maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
    -maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csfiles.label = CS Files
    maven.dashboard.aggregator.csfiles.goal = checkstyle
    maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
    @@ -109,7 +109,7 @@

    # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
    maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
    -maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csall.label = CS err/warn
    maven.dashboard.aggregator.csall.goal = checkstyle
    maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
    @@ -117,7 +117,7 @@
  1. Properties for the Checkstyle error aggregator (only errors)
    maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
    -maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cserrors.label = CS errors
    maven.dashboard.aggregator.cserrors.goal = checkstyle
    maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
    @@ -125,7 +125,7 @@

    # Properties for the Checkstyle warning aggregator (only warnings)
    maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
    -maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cswarnings.label = CS warnings
    maven.dashboard.aggregator.cswarnings.goal = checkstyle
    maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Arnaud Heritier added a comment -

Thanks Carlos. I forgot to update those properties.

Show
Arnaud Heritier added a comment - Thanks Carlos. I forgot to update those properties.
Hide
Permalink
Carlos Sanchez added a comment -

Please revert the changes, they shouldn't be applied until checkstyle plugin 3.0 is released

Show
Carlos Sanchez added a comment - Please revert the changes, they shouldn't be applied until checkstyle plugin 3.0 is released
Hide
Permalink
Arnaud Heritier added a comment -

Do you think we'll release the dashboard plugin before the checkstyle plugin ?
I already updated cs*.report properties because without it the tests in the dashboard fails
We can add a dependency test on the dashboard plugin to check that at least the checkstyle plugin 3.0 is installed.
But I'm not sure it's a good idea because a user can use this dashboard plugin with an old checkstyle plugin if he redefine some properties...
WDYT ?

Show
Arnaud Heritier added a comment - Do you think we'll release the dashboard plugin before the checkstyle plugin ? I already updated cs*.report properties because without it the tests in the dashboard fails We can add a dependency test on the dashboard plugin to check that at least the checkstyle plugin 3.0 is installed. But I'm not sure it's a good idea because a user can use this dashboard plugin with an old checkstyle plugin if he redefine some properties... WDYT ?
Hide
Permalink
Carlos Sanchez added a comment -

I've added a section to the docs saying how to use checkstyle with older dashboard plugins. We should stay with the old dashboard prperties until 3.0 is released. You can change the properties in project.properties in the plugin test to prevent the failure.

Show
Carlos Sanchez added a comment - I've added a section to the docs saying how to use checkstyle with older dashboard plugins. We should stay with the old dashboard prperties until 3.0 is released. You can change the properties in project.properties in the plugin test to prevent the failure.
Hide
Permalink
Arnaud Heritier added a comment -

You forgot to document these properties :

maven.dashboard.aggregator.csfiles.report = checkstyle/index.html
maven.dashboard.aggregator.csall.report = checkstyle/index.html
maven.dashboard.aggregator.cserrors.report = checkstyle/index.html
maven.dashboard.aggregator.cswarnings.report = checkstyle/index.html

Personnally , I think we'll release all these plugins before the beta 3 and we are likely to forgot to update these properties before we release the dashboard plugin.
I don't find that it's a proplem to anticipate the changes ?

Vincent, you are the RM, WDYT ?

Show
Arnaud Heritier added a comment - You forgot to document these properties : maven.dashboard.aggregator.csfiles.report = checkstyle/index.html maven.dashboard.aggregator.csall.report = checkstyle/index.html maven.dashboard.aggregator.cserrors.report = checkstyle/index.html maven.dashboard.aggregator.cswarnings.report = checkstyle/index.html Personnally , I think we'll release all these plugins before the beta 3 and we are likely to forgot to update these properties before we release the dashboard plugin. I don't find that it's a proplem to anticipate the changes ? Vincent, you are the RM, WDYT ?
Hide
Permalink
Carlos Sanchez added a comment -

That properties were not changed this time, so they were left bad documented previously.

The checkstyle plugin 3.0 won't be in 1.1 because it uses a beta version of checkstyle and introduces a lot of new features and changes that were not in previous 1.1betas.

Show
Carlos Sanchez added a comment - That properties were not changed this time, so they were left bad documented previously. The checkstyle plugin 3.0 won't be in 1.1 because it uses a beta version of checkstyle and introduces a lot of new features and changes that were not in previous 1.1betas.
Hide
Permalink
Arnaud Heritier added a comment -

I changed these properties some days ago :
http://marc.theaimsgroup.com/?l=turbine-maven-dev&m=112807420610863&w=2

Ok, if you think we'll not bundle it in m1.1 we can revert it.

Show
Arnaud Heritier added a comment - I changed these properties some days ago : http://marc.theaimsgroup.com/?l=turbine-maven-dev&m=112807420610863&w=2 Ok, if you think we'll not bundle it in m1.1 we can revert it.
Hide
Permalink
Lukas Theussl added a comment -

Arnaud, Carlos: what is the status of this issue? I would also prefer to include checkstyle plugin 3.0 in m1.1 (now it doesn't use beta dependencies anymore).

Show
Lukas Theussl added a comment - Arnaud, Carlos: what is the status of this issue? I would also prefer to include checkstyle plugin 3.0 in m1.1 (now it doesn't use beta dependencies anymore).
Hide
Permalink
Arnaud Heritier added a comment -

I'm also in favor to release it and to include it in the beta 3

Show
Arnaud Heritier added a comment - I'm also in favor to release it and to include it in the beta 3
Hide
Permalink
Carlos Sanchez added a comment -

I agree, it can be included in 1.1

Show
Carlos Sanchez added a comment - I agree, it can be included in 1.1
Hide
Permalink
Lukas Theussl added a comment -

Will release checkstyle and dashboard together this week.

Show
Lukas Theussl added a comment - Will release checkstyle and dashboard together this week.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.