Issue Details (XML | Word | Printable)

Key: MPDASHBOARD-33
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Arnaud Heritier
Reporter: Carlos Sanchez
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Dashboard Plugin

Change location of checkstyle files after releasing checkstyle plugin 3.0

Created: 05/Oct/05 04:51 PM   Updated: 30/Jan/06 01:07 PM   Resolved: 30/Jan/06 01:07 PM
Return to search
Component/s: None
Affects Version/s: 1.9
Fix Version/s: 1.9

Time Tracking:
Not Specified


 Description  « Hide

The location of the checkstyle files changes in 3.0 version of the plugin, so update the dashboard properties accordingly

Index: plugin.properties
===================================================================
— plugin.properties (revision 295118)
+++ plugin.properties (working copy)
@@ -96,7 +96,7 @@

  1. Properties for the Checkstyle files aggregator
    maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
    -maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csfiles.label = CS Files
    maven.dashboard.aggregator.csfiles.goal = checkstyle
    maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
    @@ -104,7 +104,7 @@

    # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
    maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
    -maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csall.label = CS err/warn
    maven.dashboard.aggregator.csall.goal = checkstyle
    maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
    @@ -112,7 +112,7 @@
  1. Properties for the Checkstyle error aggregator (only errors)
    maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
    -maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cserrors.label = CS errors
    maven.dashboard.aggregator.cserrors.goal = checkstyle
    maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
    @@ -120,7 +120,7 @@

    # Properties for the Checkstyle warning aggregator (only warnings)
    maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
    -maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cswarnings.label = CS warnings
    maven.dashboard.aggregator.cswarnings.goal = checkstyle
    maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings

Index: xdocs/properties.xml
===================================================================
— xdocs/properties.xml (revision 295118)
+++ xdocs/properties.xml (working copy)
@@ -101,7 +101,7 @@

  1. Properties for the Checkstyle files aggregator
    maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
    -maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csfiles.label = CS Files
    maven.dashboard.aggregator.csfiles.goal = checkstyle
    maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
    @@ -109,7 +109,7 @@

    # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
    maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
    -maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.csall.label = CS err/warn
    maven.dashboard.aggregator.csall.goal = checkstyle
    maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
    @@ -117,7 +117,7 @@
  1. Properties for the Checkstyle error aggregator (only errors)
    maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
    -maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cserrors.label = CS errors
    maven.dashboard.aggregator.cserrors.goal = checkstyle
    maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
    @@ -125,7 +125,7 @@

    # Properties for the Checkstyle warning aggregator (only warnings)
    maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
    -maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
    +maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
    maven.dashboard.aggregator.cswarnings.label = CS warnings
    maven.dashboard.aggregator.cswarnings.goal = checkstyle
    maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings

Sort Order: Ascending order - Click to sort in descending order
Carlos Sanchez made changes - 05/Oct/05 04:54 PM
Field Original Value New Value
Description The location of the checkstyle files changes in 3.0 version of the plugin, so update the dashboard properties accordingly

Index: plugin.properties
===================================================================
--- plugin.properties (revision 295118)
+++ plugin.properties (working copy)
@@ -96,7 +96,7 @@
 
 # Properties for the Checkstyle files aggregator
 maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
-maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csfiles.label = CS Files
 maven.dashboard.aggregator.csfiles.goal = checkstyle
 maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
@@ -104,7 +104,7 @@
 
 # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
 maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
-maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csall.label = CS err/warn
 maven.dashboard.aggregator.csall.goal = checkstyle
 maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
@@ -112,7 +112,7 @@
 
 # Properties for the Checkstyle error aggregator (only errors)
 maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
-maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cserrors.label = CS errors
 maven.dashboard.aggregator.cserrors.goal = checkstyle
 maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
@@ -120,7 +120,7 @@
 
 # Properties for the Checkstyle warning aggregator (only warnings)
 maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
-maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cswarnings.label = CS warnings
 maven.dashboard.aggregator.cswarnings.goal = checkstyle
 maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings
 The location of the checkstyle files changes in 3.0 version of the plugin, so update the dashboard properties accordingly

Index: plugin.properties
===================================================================
--- plugin.properties (revision 295118)
+++ plugin.properties (working copy)
@@ -96,7 +96,7 @@
 
 # Properties for the Checkstyle files aggregator
 maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
-maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csfiles.label = CS Files
 maven.dashboard.aggregator.csfiles.goal = checkstyle
 maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
@@ -104,7 +104,7 @@
 
 # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
 maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
-maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csall.label = CS err/warn
 maven.dashboard.aggregator.csall.goal = checkstyle
 maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
@@ -112,7 +112,7 @@
 
 # Properties for the Checkstyle error aggregator (only errors)
 maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
-maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cserrors.label = CS errors
 maven.dashboard.aggregator.cserrors.goal = checkstyle
 maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
@@ -120,7 +120,7 @@
 
 # Properties for the Checkstyle warning aggregator (only warnings)
 maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
-maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cswarnings.label = CS warnings
 maven.dashboard.aggregator.cswarnings.goal = checkstyle
 maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings


Index: xdocs/properties.xml
===================================================================
--- xdocs/properties.xml (revision 295118)
+++ xdocs/properties.xml (working copy)
@@ -101,7 +101,7 @@
 
 # Properties for the Checkstyle files aggregator
 maven.dashboard.aggregator.csfiles.script = ${maven.dashboard.aggregators.dir}/csfiles.jelly
-maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csfiles.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csfiles.label = CS Files
 maven.dashboard.aggregator.csfiles.goal = checkstyle
 maven.dashboard.aggregator.csfiles.description = Number of files checked with Checkstyle
@@ -109,7 +109,7 @@
 
 # Properties for the Checkstyle error/warning aggregator (all errors/warnings)
 maven.dashboard.aggregator.csall.script = ${maven.dashboard.aggregators.dir}/csall.jelly
-maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.csall.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.csall.label = CS err/warn
 maven.dashboard.aggregator.csall.goal = checkstyle
 maven.dashboard.aggregator.csall.description = Number of Checkstyle errors and warnings
@@ -117,7 +117,7 @@
 
 # Properties for the Checkstyle error aggregator (only errors)
 maven.dashboard.aggregator.cserrors.script = ${maven.dashboard.aggregators.dir}/cserrors.jelly
-maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cserrors.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cserrors.label = CS errors
 maven.dashboard.aggregator.cserrors.goal = checkstyle
 maven.dashboard.aggregator.cserrors.description = Number of Checkstyle errors
@@ -125,7 +125,7 @@
 
 # Properties for the Checkstyle warning aggregator (only warnings)
 maven.dashboard.aggregator.cswarnings.script = ${maven.dashboard.aggregators.dir}/cswarnings.jelly
-maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle-raw-report.xml
+maven.dashboard.aggregator.cswarnings.artifact = ${maven.build.dir}/checkstyle/checkstyle-raw-report.xml
 maven.dashboard.aggregator.cswarnings.label = CS warnings
 maven.dashboard.aggregator.cswarnings.goal = checkstyle
 maven.dashboard.aggregator.cswarnings.description = Number of Checkstyle warnings
[ Permalink | « Hide ]
Arnaud Heritier added a comment - 05/Oct/05 05:09 PM

Thanks Carlos. I forgot to update those properties.


Arnaud Heritier made changes - 05/Oct/05 05:09 PM
Assignee Arnaud Heritier [ aheritier ]
Fix Version/s 1.9 [ 11720 ]
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Carlos Sanchez added a comment - 05/Oct/05 05:13 PM

Please revert the changes, they shouldn't be applied until checkstyle plugin 3.0 is released


Carlos Sanchez made changes - 05/Oct/05 05:13 PM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
[ Permalink | « Hide ]
Arnaud Heritier added a comment - 05/Oct/05 05:20 PM

Do you think we'll release the dashboard plugin before the checkstyle plugin ?
I already updated cs*.report properties because without it the tests in the dashboard fails
We can add a dependency test on the dashboard plugin to check that at least the checkstyle plugin 3.0 is installed.
But I'm not sure it's a good idea because a user can use this dashboard plugin with an old checkstyle plugin if he redefine some properties...
WDYT ?


[ Permalink | « Hide ]
Carlos Sanchez added a comment - 05/Oct/05 05:34 PM

I've added a section to the docs saying how to use checkstyle with older dashboard plugins. We should stay with the old dashboard prperties until 3.0 is released. You can change the properties in project.properties in the plugin test to prevent the failure.


[ Permalink | « Hide ]
Arnaud Heritier added a comment - 05/Oct/05 06:02 PM

You forgot to document these properties :

maven.dashboard.aggregator.csfiles.report = checkstyle/index.html
maven.dashboard.aggregator.csall.report = checkstyle/index.html
maven.dashboard.aggregator.cserrors.report = checkstyle/index.html
maven.dashboard.aggregator.cswarnings.report = checkstyle/index.html

Personnally , I think we'll release all these plugins before the beta 3 and we are likely to forgot to update these properties before we release the dashboard plugin.
I don't find that it's a proplem to anticipate the changes ?

Vincent, you are the RM, WDYT ?


[ Permalink | « Hide ]
Carlos Sanchez added a comment - 05/Oct/05 06:25 PM

That properties were not changed this time, so they were left bad documented previously.

The checkstyle plugin 3.0 won't be in 1.1 because it uses a beta version of checkstyle and introduces a lot of new features and changes that were not in previous 1.1betas.


[ Permalink | « Hide ]
Arnaud Heritier added a comment - 05/Oct/05 06:42 PM

I changed these properties some days ago :
http://marc.theaimsgroup.com/?l=turbine-maven-dev&m=112807420610863&w=2

Ok, if you think we'll not bundle it in m1.1 we can revert it.


[ Permalink | « Hide ]
Lukas Theussl added a comment - 11/Jan/06 06:11 PM

Arnaud, Carlos: what is the status of this issue? I would also prefer to include checkstyle plugin 3.0 in m1.1 (now it doesn't use beta dependencies anymore).


[ Permalink | « Hide ]
Arnaud Heritier added a comment - 11/Jan/06 06:17 PM

I'm also in favor to release it and to include it in the beta 3


[ Permalink | « Hide ]
Carlos Sanchez added a comment - 24/Jan/06 03:28 PM

I agree, it can be included in 1.1


[ Permalink | « Hide ]
Lukas Theussl added a comment - 30/Jan/06 01:07 PM

Will release checkstyle and dashboard together this week.


Lukas Theussl made changes - 30/Jan/06 01:07 PM
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Atlassian JIRA (v4.0#466) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.