Issue Details (XML | Word | Printable)

Key: MPDASHBOARD-32
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Wim Deblauwe
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Dashboard Plugin

maven.dashboard.report.showempty property not honoured when using Maven 1.1b1

Created: 06/Sep/05 05:34 AM   Updated: 10/Jan/06 07:09 PM   Resolved: 10/Jan/06 07:09 PM
Return to search
Component/s: None
Affects Version/s: 1.8
Fix Version/s: 1.9

Time Tracking:
Not Specified

Environment:
Maven 1.1beta1
Windows XP


 Description  « Hide

When using the 'maven.dashboard.report.showempty' property, the dashboard overview still shows the empty reports. The problem seems to be with the isEmpty() call.

The orginal code is like this (in dashboard.jsl):

<!-- Decide whether to display project data -->
<j:set var="shallDisplay" value="true"/>
<j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
<x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
<j:if test="${notEmptyElems.isEmpty() == 'true'}">
<j:set var="shallDisplay" value="false"/>
</j:if>
</j:if>

It should be changed to this:

<!-- Decide whether to display project data -->
<j:set var="shallDisplay" value="true"/>
<j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
<x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
<j:if test="${empty(notEmptyElems)}"> <!-- THIS LINE CHANGED -->
<j:set var="shallDisplay" value="false"/>
</j:if>
</j:if>

I tested this and it works fine with my little change.

regards,

Wim



Lukas Theussl made changes - 10/Jan/06 07:09 PM
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.9 [ 11720 ]