Maven 1.x Dashboard Plugin

maven.dashboard.report.showempty property not honoured when using Maven 1.1b1

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.9
  • Component/s: None
  • Labels:
    None
  • Environment:
    Maven 1.1beta1
    Windows XP
  • Number of attachments :
    0

Description

When using the 'maven.dashboard.report.showempty' property, the dashboard overview still shows the empty reports. The problem seems to be with the isEmpty() call.

The orginal code is like this (in dashboard.jsl):

<!-- Decide whether to display project data -->
<j:set var="shallDisplay" value="true"/>
<j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
<x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
<j:if test="${notEmptyElems.isEmpty() == 'true'}">
<j:set var="shallDisplay" value="false"/>
</j:if>
</j:if>

It should be changed to this:

<!-- Decide whether to display project data -->
<j:set var="shallDisplay" value="true"/>
<j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
<x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
<j:if test="${empty(notEmptyElems)}"> <!-- THIS LINE CHANGED -->
<j:set var="shallDisplay" value="false"/>
</j:if>
</j:if>

I tested this and it works fine with my little change.

regards,

Wim

Activity

There are no comments yet on this issue.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: