Maven 1.x Dashboard Plugin

Dashboard does not respect setting of maven.multiproject.includes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.9
  • Component/s: None
  • Labels:
    None
  • Environment:
    Maven 1.02
  • Number of attachments :
    0

Description

The dashboard docs say:

  1. Location of subprojects to include in the dashboard report. By default
  2. these properties have the same values as their Multiproject conterpart.
  3. You can define them if you need to set different values.
    #maven.dashboard.basedir=${basedir}
    #maven.dashboard.includes=*/project.xml
    #maven.dashboard.excludes=
    #maven.dashboard.ignoreFailures=false

I interpret this to mean "maven.dashboard.includes" will match the setting of "maven.multiproject.includes" (as well as the rest of the settings listed).

However, if I set "maven.multiproject.includes" to only one of my subprojects (e.g. "subprojname/project.xml"), dashboard still runs on all of them.

If this is working as designed, then I suggest changing the doc words to something like:

  1. Location of subprojects to include in the dashboard report. By default,
  2. these properties have the same default values as their Multiproject counterpart, but
  3. do not use any user-made settings to the Multiproject properties.

Activity

Hide
Eric Ballet Baz added a comment -

Furthermore properties :
maven.dashboard.basedir
maven.dashboard.includes
maven.dashboard.excludes
maven.dashboard.ignoreFailures
are now always ignored ... It's not possible anymore to override multiproject properties

Show
Eric Ballet Baz added a comment - Furthermore properties : maven.dashboard.basedir maven.dashboard.includes maven.dashboard.excludes maven.dashboard.ignoreFailures are now always ignored ... It's not possible anymore to override multiproject properties
Hide
Vincent Massol added a comment -

"I interpret this to mean "maven.dashboard.includes" will match the setting of "maven.multiproject.includes" (as well as the rest of the settings listed). "

Yes, this is what it means.

Are you using the latest version of the dashboard plugin: v1.8?

Show
Vincent Massol added a comment - "I interpret this to mean "maven.dashboard.includes" will match the setting of "maven.multiproject.includes" (as well as the rest of the settings listed). " Yes, this is what it means. Are you using the latest version of the dashboard plugin: v1.8?
Hide
Vincent Massol added a comment -

Eric, I'll check this... Thanks

Show
Vincent Massol added a comment - Eric, I'll check this... Thanks
Hide
Jeff Jensen added a comment -

Hmm. I just tried with Maven 1.1 snapshot, which includes dashboard 1.9 snapshot. The problem did not occur for the dashboard.includes. I did not test the others as reported by Eric.

Show
Jeff Jensen added a comment - Hmm. I just tried with Maven 1.1 snapshot, which includes dashboard 1.9 snapshot. The problem did not occur for the dashboard.includes. I did not test the others as reported by Eric.
Hide
Eric Ballet Baz added a comment -

Just have a look at the plugin.jelly file. Properties like maven.dashboard.includes, maven.dashboard.basedir ... are not used anymore.

Furthermore when looking at this file, it seems also that default values are not used : dBasedir, dIncludes, dExcludes, dIgnoreFailures : defined but not used.

Thx

Show
Eric Ballet Baz added a comment - Just have a look at the plugin.jelly file. Properties like maven.dashboard.includes, maven.dashboard.basedir ... are not used anymore. Furthermore when looking at this file, it seems also that default values are not used : dBasedir, dIncludes, dExcludes, dIgnoreFailures : defined but not used. Thx
Hide
Vincent Massol added a comment -

Jeff and Eric, could you please try with the version in SVN trunk. I think I have fixed both issues but I'm not 100% sure. I would also need to add some tests but it's not very easy to do so... We'll reopen if it's not fixed.

Show
Vincent Massol added a comment - Jeff and Eric, could you please try with the version in SVN trunk. I think I have fixed both issues but I'm not 100% sure. I would also need to add some tests but it's not very easy to do so... We'll reopen if it's not fixed.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: