Issue Details (XML | Word | Printable)

Key: MPCRUISECONTROL-8
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Brett Porter
Reporter: Paul Spencer
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x CruiseControl Plugin

External link for report should not include artifactId

Created: 16/Jul/04 01:28 PM   Updated: 24/Jul/04 06:17 AM   Resolved: 23/Jul/04 05:06 AM
Return to search
Component/s: None
Affects Version/s: 1.4
Fix Version/s: 1.5

Time Tracking:
Not Specified


 Description  « Hide

I am using one instance of CruiseControl to may maven projects. I would like to use the CruiseControl report, but the externalLink is includes the artifact Id. Since the property maven.cruisecontrol.buildresults.url can be defined for each project, I dot see a reason for the plugin to append the artifactId.

My request is to change the maven-cruisecontrol-plugin:register goal in plugin.jelly from:

<goal name="maven-cruisecontrol-plugin:register">
<doc:registerReport
name="CC Build Results"
pluginName="maven-cruisecontrol-plugin" externalLink="${maven.cruisecontrol.buildresults.url}/${pom.artifactId}"
description="See the cruise control build results page for this project." />
</goal>

To:

<goal name="maven-cruisecontrol-plugin:register">
<doc:registerReport
name="CC Build Results"
pluginName="maven-cruisecontrol-plugin"
externalLink="${maven.cruisecontrol.buildresults.url}"
description="See the cruise control build results page for this project." />
</goal>

Also the properties.xml and goals.xml need to be updated.



Paul Spencer added a comment - 16/Jul/04 01:50 PM

A better solution it to calculate the URL in properties. This gives the user more control, while allowing reasonable defaults. By calculating maven.cruisecontrol.buildresults.url in properties, then CruiseControls LinkEmailPublisher instead of the HTMLEmailPublisher can be used.

maven.cruisecontrol.buildresults.site=${pom.url}/cruisecontrol
maven.cruisecontrol.buildresults.url=${maven.cruisecontrol.buildresults.site}/buildresults/${pom.artifactId}

I am assuming pom.url is the from <project><url>

Paul Spencer


David Eric Pugh added a comment - 22/Jul/04 03:34 AM

I like the second approach with the properties being used to build up the url. The real fix though would be to just download the cc report! However, I haven't quite figured out how to do that yet!

Can you submit a patch file and I'll make the change?


David Eric Pugh added a comment - 23/Jul/04 05:06 AM

Ok, I took care of this one..


David Eric Pugh made changes - 23/Jul/04 05:06 AM
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Fix Version/s 1.5 [ 10910 ]
Paul Spencer added a comment - 24/Jul/04 06:17 AM

The property maven.cruisecontrol.buildresults.url is defined twice in plugin.properties. Other then that, it looks good.