Maven 1.x CruiseControl Plugin

Corrected the baseUrl

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.6
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Subversion FC3
  • Number of attachments :
    2

Description

Here is the additional setting for the baseUrl, simply allows you to override the ${url} for the subversion repository so that modifications that are in subjects that are at the same level as the master project can be pick up.

Attached in the SVN diff, hopefully I got it right this time. Sorry about the previous RAR file.

Attachments

  1. File
    cruisecontrol.diff
    06/May/05 7:44 AM
    8 kB
    Philip Dodds
  2. File
    cruisecontrol.diff
    04/May/05 9:16 PM
    2 kB
    Philip Dodds

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

close

now, I'm not entirely certain, but I don't think ${url} will be populated correctly as the default. Can you confirm you have tested that?

Aside from that, should it also be used for CVS? If not, maybe a .svn. in the property is appropriate?

The patch format is good though, thanks very much for that.

Show
Brett Porter added a comment - close now, I'm not entirely certain, but I don't think ${url} will be populated correctly as the default. Can you confirm you have tested that? Aside from that, should it also be used for CVS? If not, maybe a .svn. in the property is appropriate? The patch format is good though, thanks very much for that.
Hide
Permalink
Philip Dodds added a comment -

I had a look at the baseUrl usuage and it was a bit of a hack for my environment so yesterday afternoon I changes the plugin to determine the modification set based on the reactor if the mmaven.cruisecontrol.multiproject=true is set, it was a bit more tricky but got me the result I was looking for. The same code should work for CVS and I tested it on single projects.

Show
Philip Dodds added a comment - I had a look at the baseUrl usuage and it was a bit of a hack for my environment so yesterday afternoon I changes the plugin to determine the modification set based on the reactor if the mmaven.cruisecontrol.multiproject=true is set, it was a bit more tricky but got me the result I was looking for. The same code should work for CVS and I tested it on single projects.
Hide
Permalink
Brett Porter added a comment -

Assigning to Vincent as he was planning to cut a release of this. Vincent, please review and apply this patch if you think it is appropriate.

One comment: I wouldn't use pom.context.getMavenSession().getRootContext.getVariable(...). I'm not sure why you need that, but I think it is equivalent to the more readable:
<j:set var="list" value="..." scope="parent" />
<j:forEach items="${list}" ... >

Show
Brett Porter added a comment - Assigning to Vincent as he was planning to cut a release of this. Vincent, please review and apply this patch if you think it is appropriate. One comment: I wouldn't use pom.context.getMavenSession().getRootContext.getVariable(...). I'm not sure why you need that, but I think it is equivalent to the more readable: <j:set var="list" value="..." scope="parent" /> <j:forEach items="${list}" ... >
Hide
Permalink
Vincent Massol added a comment -

Not working on this so leaving it unassigned for anyone interested to take it up.

Show
Vincent Massol added a comment - Not working on this so leaving it unassigned for anyone interested to take it up.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.