Issue Details (XML | Word | Printable)

Key: MPCRUISECONTROL-24
Type: New Feature New Feature
Status: Open Open
Priority: Minor Minor
Assignee: Unassigned
Reporter: Philip Dodds
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x CruiseControl Plugin

Corrected the baseUrl

Created: 04/May/05 09:16 PM   Updated: 05/May/06 03:52 PM
Component/s: None
Affects Version/s: 1.6
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. File cruisecontrol.diff (8 kB)
2. File cruisecontrol.diff (2 kB)

Environment: Subversion FC3


 Description  « Hide

Here is the additional setting for the baseUrl, simply allows you to override the ${url} for the subversion repository so that modifications that are in subjects that are at the same level as the master project can be pick up.

Attached in the SVN diff, hopefully I got it right this time. Sorry about the previous RAR file.



Brett Porter added a comment - 04/May/05 09:23 PM

close

now, I'm not entirely certain, but I don't think ${url} will be populated correctly as the default. Can you confirm you have tested that?

Aside from that, should it also be used for CVS? If not, maybe a .svn. in the property is appropriate?

The patch format is good though, thanks very much for that.


Philip Dodds added a comment - 06/May/05 07:44 AM

I had a look at the baseUrl usuage and it was a bit of a hack for my environment so yesterday afternoon I changes the plugin to determine the modification set based on the reactor if the mmaven.cruisecontrol.multiproject=true is set, it was a bit more tricky but got me the result I was looking for. The same code should work for CVS and I tested it on single projects.


Brett Porter added a comment - 18/May/05 07:36 PM

Assigning to Vincent as he was planning to cut a release of this. Vincent, please review and apply this patch if you think it is appropriate.

One comment: I wouldn't use pom.context.getMavenSession().getRootContext.getVariable(...). I'm not sure why you need that, but I think it is equivalent to the more readable:
<j:set var="list" value="..." scope="parent" />
<j:forEach items="${list}" ... >


Vincent Massol added a comment - 31/Mar/06 04:55 AM

Not working on this so leaving it unassigned for anyone interested to take it up.