Maven 1.x Clover Plugin

clover:off does not reset the compiler to javac

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.8
  • Fix Version/s: 1.9
  • Component/s: None
  • Labels:
    None
  • Environment:
    maven clover plugin 1.8
    clover version 1.3.5
  • Number of attachments :
    0

Description

I have the problem that when calling clover:off the java compiler is not reset to javac. Any report I run after the clover one in 'maven site' that needs to compile still uses the clover compiler.

Am I missing something? I see the build.compiler property is reset to an emtpy string (or just removed from the env), but no <ant clover:desetup> is called (since it does not exist).

Activity

Hide
Wim Deblauwe added a comment -

clover:off needs to disable the clover compiler like this:

<ant:clover-setup
initstring="${maven.clover.database}"
flushpolicy="interval"
flushinterval="500"
enabled="false"/>

There is however a pitfall to this:
Calling 'maven clover:on jar clover:off jar' will produce a clovered jar! That is because maven/ant sees that the classes are already compiled. You need to do a clean in between.

I use this to generate a nightly build with a website with Clover, but have a "clean" jar deployed at our server repository.

Show
Wim Deblauwe added a comment - clover:off needs to disable the clover compiler like this: <ant:clover-setup initstring="${maven.clover.database}" flushpolicy="interval" flushinterval="500" enabled="false"/> There is however a pitfall to this: Calling 'maven clover:on jar clover:off jar' will produce a clovered jar! That is because maven/ant sees that the classes are already compiled. You need to do a clean in between. I use this to generate a nightly build with a website with Clover, but have a "clean" jar deployed at our server repository.
Hide
Vincent Massol added a comment -

Thanks Wim. A patch with some test cases would be just awesome but I guess I can't ask for too much Your information about clover-setup with enabled="false" has helped me a lot. Thanks.

Show
Vincent Massol added a comment - Thanks Wim. A patch with some test cases would be just awesome but I guess I can't ask for too much Your information about clover-setup with enabled="false" has helped me a lot. Thanks.

People

Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: