Maven 1.x Checkstyle Plugin

Turbine checkstyle rules do not match Turbine coding rules

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 3.0
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

The maven-checkstyle plugin contains the following rule for the Turbine checkstyle mode:

<module name="MemberName">
<property name="format" value="^f[A-Z][a-zA-Z0-9]*$"/>
</module>

which is silly. Such a rule was never part of the Turbine coding style rules. Please remove these.

Activity

Hide
Carlos Sanchez added a comment -

some resource where we can confirm this ?

Show
Carlos Sanchez added a comment - some resource where we can confirm this ?
Hide
Henning Schmiedehausen added a comment -

(So the current lag seems to be six months?)

http://jakarta.apache.org/turbine/common/code-standards.html

e.g.

Or you can simply trust me. I'm a committer on the Turbine project.

Show
Henning Schmiedehausen added a comment - (So the current lag seems to be six months?) http://jakarta.apache.org/turbine/common/code-standards.html e.g. Or you can simply trust me. I'm a committer on the Turbine project.
Hide
Carlos Sanchez added a comment -

Ok, if you're a comitter that's enough You should know that a diff patch always makes things get fixed faster.
I'll change it to <module name="MemberName"/> , wich I think it's the Sun convention one.

Show
Carlos Sanchez added a comment - Ok, if you're a comitter that's enough You should know that a diff patch always makes things get fixed faster. I'll change it to <module name="MemberName"/> , wich I think it's the Sun convention one.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
10m
Original Estimate - 10 minutes
Remaining:
10m
Remaining Estimate - 10 minutes
Logged:
Not Specified
Time Spent - Not Specified