Maven 1.x Checkstyle Plugin

Maven checkstyle plugin doesn't support severity

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

The maven plugin currently doesn't show the severity of each check in the report. It makes it really to use on projects taking in account this new checkstyle feature.

Attachments

  1. XML File
    checkstyle.jsl
    13/Nov/03 6:18 PM
    6 kB
    Henri Tremblay
  2. Text File
    diff.txt
    13/Nov/03 6:19 PM
    2 kB
    Henri Tremblay

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Henri Tremblay added a comment -

Here is the fix. It's a modified version of the file currently available in the head branch.

Show
Henri Tremblay added a comment - Here is the fix. It's a modified version of the file currently available in the head branch.
Hide
Permalink
Henri Tremblay added a comment -

And here's the diff

Show
Henri Tremblay added a comment - And here's the diff
Hide
Permalink
Vincent Massol added a comment -

Next time, please use a unified diff and send a real patch: "cvs diff". Thanks.

Show
Vincent Massol added a comment - Next time, please use a unified diff and send a real patch: "cvs diff". Thanks.
Hide
Permalink
Vincent Massol added a comment -

Also your patch is NOT against Maven HEAD it seems!!!! I'm hesitating to apply it...

Here's what's in HEAD:

<j:useBean var="mavenTool" class="org.apache.maven.util.MavenTool"/>

Here's what you've used:

<j:useBean var="mavenTool" class="org.apache.maven.MavenTool"/>

Show
Vincent Massol added a comment - Also your patch is NOT against Maven HEAD it seems!!!! I'm hesitating to apply it... Here's what's in HEAD: <j:useBean var="mavenTool" class="org.apache.maven.util.MavenTool"/> Here's what you've used: <j:useBean var="mavenTool" class="org.apache.maven.MavenTool"/>
Hide
Permalink
Vincent Massol added a comment -

Any reason why you've changed:

<j:set var="srcDir" value="${fileutil.file(fullSrcDir).getCanonicalPath()}"/>

to

<j:set var="srcDir" value="${fileutil.file(fullSrcDir).getAbsolutePath()}"/>

?

Show
Vincent Massol added a comment - Any reason why you've changed: <j:set var="srcDir" value="${fileutil.file(fullSrcDir).getCanonicalPath()}"/> to <j:set var="srcDir" value="${fileutil.file(fullSrcDir).getAbsolutePath()}"/> ?
Hide
Permalink
Vincent Massol added a comment -

Done with several modifications (the patch was not against head).

Show
Vincent Massol added a comment - Done with several modifications (the patch was not against head).

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.