Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.9
    • Labels:
      None
    • Number of attachments :
      3

      Description

      I write a patch for the maven-1 changelog Plugin to support the MKS scm (http://www.mks.com/products/sie). I hope you will add it to your sources. How can i send you the patch? I attach the changed files?

        Activity

        Hide
        Arnaud Heritier added a comment -

        It's easier for us if :

        • you checkout the plugin sources with a subversion client
        • you apply your modifications and add your new files
        • you generate a patch
        • you attach it to this issue
        Show
        Arnaud Heritier added a comment - It's easier for us if : you checkout the plugin sources with a subversion client you apply your modifications and add your new files you generate a patch you attach it to this issue
        Hide
        Christoph Jerolimov added a comment -

        Okay, here's a svn diff.

        Show
        Christoph Jerolimov added a comment - Okay, here's a svn diff.
        Hide
        Arnaud Heritier added a comment -

        Thanks a lot.
        We'll review it ASAP.

        Show
        Arnaud Heritier added a comment - Thanks a lot. We'll review it ASAP.
        Hide
        Lukas Theussl added a comment -

        Thanks for your contribution Christoph!

        There are two things missing before we can apply your patch:

        • some test cases that show that your code works (in src/test)
        • documentation updates (in xdocs/)

        Do you think you can do that?

        Show
        Lukas Theussl added a comment - Thanks for your contribution Christoph! There are two things missing before we can apply your patch: some test cases that show that your code works (in src/test) documentation updates (in xdocs/) Do you think you can do that?
        Hide
        Christoph Jerolimov added a comment -

        Hello Lukas, yes i think i can do that.

        Here the new version of my diff: "mks.diff"

        • Its only update the informationen which scm the changelog plugin assits. (A "real" documentation do not exist, or?)
        • It include an mks-logfile and a TestCase.

        Bye

        Show
        Christoph Jerolimov added a comment - Hello Lukas, yes i think i can do that. Here the new version of my diff: "mks.diff" Its only update the informationen which scm the changelog plugin assits. (A "real" documentation do not exist, or?) It include an mks-logfile and a TestCase. Bye
        Hide
        Lukas Theussl added a comment -

        Excellent, thanks a lot Christoph!
        I have reviewed your patch and it looks good. I will commit it after a few cosmetic changes. Just one note to be on the safe side: one of the source files does not have a copyright notice. I assume that you are aware that by submitting a patch here, you agree to put it under the ASL2 license.

        Show
        Lukas Theussl added a comment - Excellent, thanks a lot Christoph! I have reviewed your patch and it looks good. I will commit it after a few cosmetic changes. Just one note to be on the safe side: one of the source files does not have a copyright notice. I assume that you are aware that by submitting a patch here, you agree to put it under the ASL2 license.
        Hide
        Lukas Theussl added a comment -

        Patch applied. Thanks!

        Show
        Lukas Theussl added a comment - Patch applied. Thanks!

          People

          • Assignee:
            Unassigned
            Reporter:
            Christoph Jerolimov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: