Issue Details (XML | Word | Printable)

Key: MPCHANGELOG-80
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Christoph Jerolimov
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Changelog Plugin

MKS Support

Created: 13/Jan/06 03:22 AM   Updated: 19/Jan/06 01:29 PM   Resolved: 19/Jan/06 01:29 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 1.9

Time Tracking:
Not Specified

File Attachments: 1. Zip Archive changelog-mks-support.zip (9 kB)
2. Text File changelog-mks.diff (12 kB)
3. Text File mks.diff (20 kB)



 Description  « Hide

I write a patch for the maven-1 changelog Plugin to support the MKS scm (http://www.mks.com/products/sie). I hope you will add it to your sources. How can i send you the patch? I attach the changed files?



Arnaud Heritier added a comment - 13/Jan/06 03:59 AM

It's easier for us if :

  • you checkout the plugin sources with a subversion client
  • you apply your modifications and add your new files
  • you generate a patch
  • you attach it to this issue

Christoph Jerolimov added a comment - 13/Jan/06 04:36 AM

Okay, here's a svn diff.


Arnaud Heritier added a comment - 13/Jan/06 04:58 AM

Thanks a lot.
We'll review it ASAP.


Lukas Theussl added a comment - 13/Jan/06 03:10 PM

Thanks for your contribution Christoph!

There are two things missing before we can apply your patch:

  • some test cases that show that your code works (in src/test)
  • documentation updates (in xdocs/)

Do you think you can do that?


Christoph Jerolimov added a comment - 19/Jan/06 09:36 AM

Hello Lukas, yes i think i can do that.

Here the new version of my diff: "mks.diff"

  • Its only update the informationen which scm the changelog plugin assits. (A "real" documentation do not exist, or?)
  • It include an mks-logfile and a TestCase.

Bye


Lukas Theussl added a comment - 19/Jan/06 01:06 PM

Excellent, thanks a lot Christoph!
I have reviewed your patch and it looks good. I will commit it after a few cosmetic changes. Just one note to be on the safe side: one of the source files does not have a copyright notice. I assume that you are aware that by submitting a patch here, you agree to put it under the ASL2 license.


Lukas Theussl added a comment - 19/Jan/06 01:29 PM

Patch applied. Thanks!