Issue Details (XML | Word | Printable)

Key: MPCHANGELOG-69
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Unassigned
Reporter: Daniel Beland
Votes: 2
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Changelog Plugin

Changelog returning 0 entries on Windows with CVS (not CVSNT)

Created: 03/Aug/05 04:44 AM   Updated: 18/Jan/06 11:34 AM   Resolved: 17/Jan/06 06:17 PM
Return to search
Component/s: None
Affects Version/s: 1.8.2
Fix Version/s: 1.9

Time Tracking:
Not Specified

Environment:
Windows XP
maven 1.0.2
GNU cvs for DOS
Cygwin cvs
Issue Links:
Duplicate
 


 Description  « Hide

A change as been made for users using CVSNT to add quotes aroud dates on windows. (MPCHANGELOG-47)

However this add a bug for all other users using either cygwin's CVS or GNU cvs for DOS since it looks at the os.name value we cannot work around it.
I think it should be added as a plugin property to set if they are using CVSNT to get quotes around the dates.



Peter Lynch made changes - 15/Sep/05 11:11 PM
Field Original Value New Value
Assignee Peter Lynch [ plynch ]
Peter Lynch made changes - 15/Sep/05 11:12 PM
Assignee Peter Lynch [ plynch ]
Peter Lynch added a comment - 15/Sep/05 11:12 PM

Sorry clicked the wrong link


Lukas Theussl made changes - 03/Oct/05 11:30 AM
Description
A change as been made for users using CVSNT to add quotes aroud dates on windows. (MPCHANGELOG-47)

However this add a bug for all other users using either cygwin's CVS or GNU cvs for DOS since it looks at the os.name value we cannot work around it.
I think it should be added as a plugin property to set if they are using CVSNT to get quotes around the dates.

A change as been made for users using CVSNT to add quotes aroud dates on windows. (MPCHANGELOG-47)

However this add a bug for all other users using either cygwin's CVS or GNU cvs for DOS since it looks at the os.name value we cannot work around it.
I think it should be added as a plugin property to set if they are using CVSNT to get quotes around the dates.

Fix Version/s 1.9 [ 12040 ]
Lukas Theussl made changes - 03/Oct/05 06:06 PM
Link This issue is duplicated by MPCHANGELOG-71 [ MPCHANGELOG-71 ]
Laird Nelson added a comment - 11/Oct/05 02:01 PM

I found a hideous, hideous workaround for this, which, like everything involving Jelly, relies on some black magic that I don't understand.

Put this or something similar in your maven.xml if you have an environment like the original poster (boy, I hope this is formatted right by JIRA):

<project xmlns:ant="jelly:ant" xmlns:j="jelly:core" xmlns:maven="jelly:maven">

<j:set var="oldName" value="${systemScope['os.name']}"/>
${systemScope.setProperty('oldOSName', oldName)}

<preGoal name="maven-changelog-plugin:report">
${systemScope.setProperty('os.name', 'bogus')}
</preGoal>

<postGoal name="maven-changelog-plugin:report">
<j:set var="oldName" value="${systemScope['oldOSName']}"/>
${systemScope.setProperty('os.name', oldName)}
</postGoal>

</project>


Laird Nelson added a comment - 11/Oct/05 02:09 PM

Actually, the more I look at this bug the more weird it is. This has nothing to do with CVSNT as far as I can tell. The CvsChangeLogGenerator.java file simply quotes arguments to cvs log -d if you're on the Windows platform. But recall that ostensibly the Maven CVS infrastructure (at least on Maven 1.1b2) is all Netbeans-Java-based, so the type of client you would otherwise run is wholly irrelevant.


Lukas Theussl added a comment - 17/Jan/06 06:17 PM

Fixed by introducing a maven.changelog.quoteDate property. Please test:

maven plugin:download -Dmaven.repo.remote=http://www.ibiblio.org/maven,http://cvs.apache.org/repository/ -DgroupId=maven -DartifactId=maven-changelog-plugin -Dversion=1.9-SNAPSHOT


Lukas Theussl made changes - 17/Jan/06 06:17 PM
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Matthew Beermann added a comment - 18/Jan/06 09:17 AM

Tested and NOT fixed! Unless the "maven.changelog.quoteDate" property needs to take some value other than "true"...

maven-changelog-plugin:report:
[echo] Generating the changelog report
Server is not supporting gzip-file-contents request
ChangeSet between 2005-12-19 and 2006-01-19: 0 entries


Lukas Theussl added a comment - 18/Jan/06 11:13 AM

Use maven.changelog.quoteDate=true if you want quotes around the date argument. So in your case, I guess you want maven.changelog.quoteDate=false (no quotes). Thanks for testing!


Matthew Beermann added a comment - 18/Jan/06 11:34 AM

Works like a charm. Now if the equivalent bug (MOJO-78) could only get fixed in Maven 2 as well...