Maven 1.x Changelog Plugin

Changelog returning 0 entries on Windows with CVS (not CVSNT)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.8.2
  • Fix Version/s: 1.9
  • Component/s: None
  • Labels:
    None
  • Environment:
    Windows XP
    maven 1.0.2
    GNU cvs for DOS
    Cygwin cvs
  • Number of attachments :
    0

Description

A change as been made for users using CVSNT to add quotes aroud dates on windows. (MPCHANGELOG-47)

However this add a bug for all other users using either cygwin's CVS or GNU cvs for DOS since it looks at the os.name value we cannot work around it.
I think it should be added as a plugin property to set if they are using CVSNT to get quotes around the dates.

Issue Links

This issue is duplicated by:
MPCHANGELOG-71 Plugin can't find changes made in CVS Critical Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Lynch added a comment -

Sorry clicked the wrong link

Show
Peter Lynch added a comment - Sorry clicked the wrong link
Hide
Permalink
Laird Nelson added a comment -

I found a hideous, hideous workaround for this, which, like everything involving Jelly, relies on some black magic that I don't understand.

Put this or something similar in your maven.xml if you have an environment like the original poster (boy, I hope this is formatted right by JIRA):

<project xmlns:ant="jelly:ant" xmlns:j="jelly:core" xmlns:maven="jelly:maven">

<j:set var="oldName" value="${systemScope['os.name']}"/>
${systemScope.setProperty('oldOSName', oldName)}

<preGoal name="maven-changelog-plugin:report">
${systemScope.setProperty('os.name', 'bogus')}
</preGoal>

<postGoal name="maven-changelog-plugin:report">
<j:set var="oldName" value="${systemScope['oldOSName']}"/>
${systemScope.setProperty('os.name', oldName)}
</postGoal>

</project>

Show
Laird Nelson added a comment - I found a hideous, hideous workaround for this, which, like everything involving Jelly, relies on some black magic that I don't understand. Put this or something similar in your maven.xml if you have an environment like the original poster (boy, I hope this is formatted right by JIRA): <project xmlns:ant="jelly:ant" xmlns:j="jelly:core" xmlns:maven="jelly:maven"> <j:set var="oldName" value="${systemScope['os.name']}"/> ${systemScope.setProperty('oldOSName', oldName)} <preGoal name="maven-changelog-plugin:report"> ${systemScope.setProperty('os.name', 'bogus')} </preGoal> <postGoal name="maven-changelog-plugin:report"> <j:set var="oldName" value="${systemScope['oldOSName']}"/> ${systemScope.setProperty('os.name', oldName)} </postGoal> </project>
Hide
Permalink
Laird Nelson added a comment -

Actually, the more I look at this bug the more weird it is. This has nothing to do with CVSNT as far as I can tell. The CvsChangeLogGenerator.java file simply quotes arguments to cvs log -d if you're on the Windows platform. But recall that ostensibly the Maven CVS infrastructure (at least on Maven 1.1b2) is all Netbeans-Java-based, so the type of client you would otherwise run is wholly irrelevant.

Show
Laird Nelson added a comment - Actually, the more I look at this bug the more weird it is. This has nothing to do with CVSNT as far as I can tell. The CvsChangeLogGenerator.java file simply quotes arguments to cvs log -d if you're on the Windows platform. But recall that ostensibly the Maven CVS infrastructure (at least on Maven 1.1b2) is all Netbeans-Java-based, so the type of client you would otherwise run is wholly irrelevant.
Hide
Permalink
Lukas Theussl added a comment -

Fixed by introducing a maven.changelog.quoteDate property. Please test:

maven plugin:download -Dmaven.repo.remote=http://www.ibiblio.org/maven,http://cvs.apache.org/repository/ -DgroupId=maven -DartifactId=maven-changelog-plugin -Dversion=1.9-SNAPSHOT

Show
Lukas Theussl added a comment - Fixed by introducing a maven.changelog.quoteDate property. Please test: maven plugin:download -Dmaven.repo.remote=http://www.ibiblio.org/maven,http://cvs.apache.org/repository/ -DgroupId=maven -DartifactId=maven-changelog-plugin -Dversion=1.9-SNAPSHOT
Hide
Permalink
Matthew Beermann added a comment -

Tested and NOT fixed! Unless the "maven.changelog.quoteDate" property needs to take some value other than "true"...

maven-changelog-plugin:report:
[echo] Generating the changelog report
Server is not supporting gzip-file-contents request
ChangeSet between 2005-12-19 and 2006-01-19: 0 entries

Show
Matthew Beermann added a comment - Tested and NOT fixed! Unless the "maven.changelog.quoteDate" property needs to take some value other than "true"... maven-changelog-plugin:report: [echo] Generating the changelog report Server is not supporting gzip-file-contents request ChangeSet between 2005-12-19 and 2006-01-19: 0 entries
Hide
Permalink
Lukas Theussl added a comment -

Use maven.changelog.quoteDate=true if you want quotes around the date argument. So in your case, I guess you want maven.changelog.quoteDate=false (no quotes). Thanks for testing!

Show
Lukas Theussl added a comment - Use maven.changelog.quoteDate=true if you want quotes around the date argument. So in your case, I guess you want maven.changelog.quoteDate=false (no quotes). Thanks for testing!
Hide
Permalink
Matthew Beermann added a comment -

Works like a charm. Now if the equivalent bug (MOJO-78) could only get fixed in Maven 2 as well...

Show
Matthew Beermann added a comment - Works like a charm. Now if the equivalent bug (MOJO-78) could only get fixed in Maven 2 as well...

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.