Maven 1.x Changelog Plugin

Changelog Plugin doesn't parse .cvspass properly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.7.1
  • Fix Version/s: 1.8.2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

I have been testing Maven on Linux running Java 1.5.0_02-b09, and noticed that the Changelog plugin won't run against CVS servers. Changelog uses a java library to provide CVS connectivity instead of running CVS from the command line.

I always get a message:

org.netbeans.lib.cvsclient.connection.AuthencticationException: Wrong Password.

I discovered that the format of the cvs information in the .cvspass file differs depending on if cvs inserted it, or the create-cvspass did.

CVS looks like this:
/1 :pserver:dep4b@cvs.sourceforge.net:2401/cvsroot/maven-plugins A3333 x

changelog:create-cvspass looks like this:
:pserver:dep4b@cvs.sourceforge.net:cvsroot/maven-plugins A3333 x

I think I have a small fix for CvsConnection.java's lookupPassword() method to deal with the two types of strings. It just isn't properly implemented for the cvs generated one where your password has a " " (space) in the password name.

I wanted to see if anyone else had run across this problem...

Activity

Hide
David Eric Pugh added a comment -

It seems like things aren't properly handled when the .cvspass file starts with a /1 and the password is blank, so it ends in "A ".. That line:

/1 :pserver:user@server:2401/home/cvs A

has only 3 elements, so the password is returned as null. However, it should be returned as "A "... I think....

Show
David Eric Pugh added a comment - It seems like things aren't properly handled when the .cvspass file starts with a /1 and the password is blank, so it ends in "A ".. That line: /1 :pserver:user@server:2401/home/cvs A has only 3 elements, so the password is returned as null. However, it should be returned as "A "... I think....
Hide
David Eric Pugh added a comment -

Looks like it is sorted out now.

Show
David Eric Pugh added a comment - Looks like it is sorted out now.
Hide
Arnaud Heritier added a comment -

Fixed for a long long time ago

Show
Arnaud Heritier added a comment - Fixed for a long long time ago

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: