Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.7.2
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Changelog plugin produces invalid URLs when used with ViewCVS. According to MPCHANGELOG-10 this has already been fixed, but still this didn't work for me.

      I tried both http://host/cgi-bin/viewcvs.cgi/?root=repo and http://host/cgi-bin/viewcvs.cgi/?cvsroot=repo, but in both cases the repository path was just appended right after the URL, instead of being inserted just before query parameters, resulting invalid URL.

      Fortunately the fix is simple. In changelog.jsl the line:

      <j:when test="$

      {!empty(repositoryUrl)}

      and $

      {repositoryUrl.indexOf('?')>0}

      ">

      needs to be changed to:

      <j:when test="$

      {!empty(repositoryUrl) and repositoryUrl.indexOf('?')>0}

      ">

        Activity

        Hide
        dion gillard added a comment -

        Applied

        Show
        dion gillard added a comment - Applied

          People

          • Assignee:
            dion gillard
            Reporter:
            Juha Komulainen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: