SvnChangeLogParser breaks on Windows style usernames

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.4
  • Fix Version/s: 1.5
  • Labels:
    None
  • Environment:
    Windows and mod_svn running behind mod_auth_sspi

Description

I currently use Subversion as my source repository. I also use mod_sspi to provide authentication for users connecting to the repository.

What does this have to do with maven-changelog-plugin? Well it seems that the username Subversion stores while being protected by SSPI is in the Windows form of "DOMAIN\user". When svn outputs a revision history, this is the username it shows. Which breaks the SvnChangeLogParser since it's not expecting a '\' in the middle of a username.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1244 plugin issues to fix for RC3

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Everton added a comment -

Simple patch to fix this issue. Basically changes the username regexp to expect any series of non-whitespace characters.

Show
Dan Everton added a comment - Simple patch to fix this issue. Basically changes the username regexp to expect any series of non-whitespace characters.
Hide
Permalink
Tim Shadel added a comment -

This patch includes the fix from Dan's patch, as well as additions to the unit tests to check it.

Show
Tim Shadel added a comment - This patch includes the fix from Dan's patch, as well as additions to the unit tests to check it.
Hide
Permalink
dion gillard added a comment -

The patch looks good.

Show
dion gillard added a comment - The patch looks good.
Hide
Permalink
dion gillard added a comment -

Applied.

Show
dion gillard added a comment - Applied.

People

  • Assignee:
    Unassigned
    Reporter:
    Dan Everton
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
1h
Original Estimate - 1 hour
Remaining:
1h
Remaining Estimate - 1 hour
Logged:
Not Specified
Time Spent - Not Specified