[#MPATCH-11] Plugin generates faulty command line when originalFile and destFile parameters are used - jira.codehaus.org

Maven 2.x Patch Plugin

Plugin generates faulty command line when originalFile and destFile parameters are used

Created: 01/Jan/10 07:03 AM Updated: 01/Jan/10 07:08 AM Resolved: 01/Jan/10 07:08 AM

Component/s:

None

Affects Version/s:

1.1

Fix Version/s:

1.1.1

Time Tracking:

Not Specified

Description

« Hide

Seems like I got an update of the patch tool which does stricter cmd line parsing. As a result, today I observed the plugin IT "path with spaces" failing. The relevant part of the build.log:

[INFO] [patch:apply {execution: apply-patch-1}]
[DEBUG] Looking for patch: second.patch in: target\it\path with spaces\src\main\patches\second.patch
[INFO] Applying patch: second.patch
[INFO] cmd.exe /X /C "patch
  "M:\maven\plugins\maven-patch-plugin\target\it\path with spaces\target\test.txt"
  -o "M:\maven\plugins\maven-patch-plugin\target\it\path with spaces\target\test2.txt"
  "M:\maven\plugins\maven-patch-plugin\target\it\path with spaces\src\main\patches\second.patch"
  -p0 -l -i
  "M:\maven\plugins\maven-patch-plugin\target\it\path with spaces\src\main\patches\second.patch""
[DEBUG] patch: extra operand `M:\maven\plugins\maven-patch-plugin\target\it\path with spaces\target\test2.txt'
[DEBUG] patch: Try `patch --help' for more information.
[INFO] patch command returned: 2

Sort Order:

[ Permalink | « Hide ]

Benjamin Bentmann added a comment - 01/Jan/10 07:08 AM

Fixed in r895004.