jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 1.x Artifact Plugin
  • MPARTIFACT-4

improve handling of EJB-client and other types, according to ArtifactType class

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.1
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    any

Description

Currently, the artifact deployment code doesn't fully utilize the org.apache.maven.project.ArtifactType class in calculating file names/paths/etc. I propose improving the DefaultArtifactDeployer class to use the ArtifactType appropriate for the specified type in determining the extension for the destination file.

In short, it requires retrieving the ArtifactType enumeration constant which corresponds to the given type string, and extracting the extension from that. If the ArtifactType.findType() method fails, the type parameter passed in is returned as the extension...this all takes place in the DefaultArtifactDeployer.extensionForType() method.

Basically, I'm removing the special case for type="ejb" and using the ArtifactType.findType(type).getExtension() logic instead. If type="ejb", the returned ArtifactType will be equal to ArtifactType.EJB, so all old functionality will be preserved.

I am cross-posting this issue in conjunction with two others: one to modify the maven core to improve dependency-classpath additions based on the ArtifactType class, and another which forms the impetus of this whole effort: to improve the handling of EJB-client jars by the EJB plugin.

The EJB plugin currently generates EJB-client jars in the ${maven.build.dir} and leaves them, without support for installing or deploying them or their snapshot versions. I have fixed this, but only by adding an EJB_CLIENT type to the ArtifactType class, which allows me to use the <artifact:install.../> tags/plugin.

The high level of integration involved with adding support for new artifact types necessitates these three separate patches...I wish it didn't. I will add the other issue ID's to this issue when I have them.

The patch for this improvement is attached.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    maven-artifact-deployment-ArtifactType-enhancement.patch
    08/Dec/03 3:04 PM
    1 kB
    John Casey

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MPEJB-18 ejb:install-client is not working

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
John Casey added a comment - 08/Dec/03 3:04 PM

patch to enable default artifact deployer to use ArtifactType class.

Show
John Casey added a comment - 08/Dec/03 3:04 PM patch to enable default artifact deployer to use ArtifactType class.
Hide
Permalink
John Casey added a comment - 08/Dec/03 3:19 PM

Cross-posted with issues:

MAVEN-1068
MPEJB-2

Where the MPEJB-2 posting is actually an addendum to previous comments by other users in an existing issue, with a new patch.

Show
John Casey added a comment - 08/Dec/03 3:19 PM Cross-posted with issues: MAVEN-1068 MPEJB-2 Where the MPEJB-2 posting is actually an addendum to previous comments by other users in an existing issue, with a new patch.
Hide
Permalink
Brett Porter added a comment - 23/Jun/04 10:10 AM

handled differently - need to map the whole path, not just the extension.

Show
Brett Porter added a comment - 23/Jun/04 10:10 AM handled differently - need to map the whole path, not just the extension.

People

  • Assignee:
    Unassigned
    Reporter:
    John Casey
Vote (1)
Watch (1)

Dates

  • Created:
    08/Dec/03 3:03 PM
    Updated:
    14/Aug/05 10:17 AM
    Resolved:
    23/Jun/04 10:10 AM

Time Tracking

Estimated:
30m
Original Estimate - 30 minutes
Remaining:
30m
Remaining Estimate - 30 minutes
Logged:
Not Specified
Time Spent - Not Specified
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.