|
[
Permlink
| « Hide
]
Matt Smith added a comment - 11/Feb/04 05:56 PM
patch for orion server support
forgot to add check for all required files, was only checking for server.xml
added check for rmi.xml, data-sources.xml, jms.xml, application.xml, mime.types, principals.xml, and hsqldb.jar please ignore the orion-2.0.2.jelly files and use the orion-2.0.2.jelly2 file thanks I'd like to reopen this issue for the following reasons which I would like to work withMatt Smith to resolve:
1.) the patch adds several properties to the generic 'appserver' namespace that are not necessarily required by other servers.Example: The whole idea of this plugin and the webserver plugin also is to support a gneric interface to controlling appservers. the properties and goals defined by the plugin should not smell of one particular appserver. So I would like to find an alternate solution to adding these orion specific properties. I Have a couple ideas like adding a server/version namespace for custom properties per application server ( ex. maven.appserver.orion20x.rmi.port, or reusing existing properties ( ex. maven.appserver.port.A, maven.username ) to represent the ones needed by orion. As I do not use orion daily some help from Matt in this regard would be great. Keeping the properties as is is not scalable or manageable. If a whole bunch of custom properties start cropping up in the general namespace all unrelated to each other then this plugin will quickly become a mess. Let's figure something out....comments Matt? since this issue adds questionable properties IMO, moving priority to major to fix the already applied patch.
Hello Peter,
I agree the addition of the properties was bad on my part. I think the namespace idea is a good one, but the propeties required for orion server support as you pointed out could be solved by using existing properties(maven.username and maven.appserver.port.A). Not sure what to do about the password though. I will look into this tonight. Thanks Matt Hello Peter,
I've come up with a solution, a mixed solution. using your namespace idea. For the rmi port I have reused the maven.appserver.port.A as that seems to be the intended purpose of including the port.A, port.B, etc. I thought the username and password should have the same format and is more intuitive. Let me know what you think and I will attach the patch. I have not adjusted the documentation yet. Thanks Matt |
|||||||||||||||||||||||||||||||||||||||||||||
 |
|
New Feature
Reopened
Major
Added support for Orion appserver 2.0.2
