Issue Details (XML | Word | Printable)

Key: MPANT-9
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Arnaud Heritier
Reporter: Jan Nielsen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Ant Plugin

ant plug-in does not support proxy environments

Created: 02/Feb/04 06:28 PM   Updated: 26/Feb/05 07:37 PM   Resolved: 26/Feb/05 07:37 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 1.9

Time Tracking:
Original Estimate: 5 minutes
Original Estimate - 5 minutes
Remaining Estimate: 5 minutes
Remaining Estimate - 5 minutes
Time Spent: Not Specified
Time Spent - Not Specified

Environment: WinNT, JVM 1.3, Ant 1.5 & Ant 1.6


 Description  « Hide

When the ant plug-in produces a build.xml, the "maven.proxy.*" properties are not used in the generated build.xml file. The attached fix works in my environment.

-Jan

Index: src/plugin-resources/templates/build.jelly
===================================================================
RCS file: /home/cvspublic/maven-plugins/ant/src/plugin-resources/templates/build.jelly,v
retrieving revision 1.5
diff -u -p -r1.5 build.jelly
— src/plugin-resources/templates/build.jelly 16 Oct 2003 07:56:57 -0000 1.5
+++ src/plugin-resources/templates/build.jelly 2 Feb 2004 20:13:19 -0000
@@ -299,7 +299,13 @@
name="get-deps"
depends="init"
unless="noget">

  • +
    + <setproxy
    + proxyhost="${maven.proxy.host}"
    + proxyport="${maven.proxy.port}"
    + proxyuser="${maven.proxy.username}"
    + proxypassword="${maven.proxy.password}"/>
    +
    <j:forEach var="dep" items="${pom.dependencies}">
    <!-- note: this is a valid use of artifactDirectory -->
    <get



Arnaud Heritier added a comment - 19/Jul/04 02:18 PM

fixed. Thanks.


patrick chanezon added a comment - 30/Jul/04 03:25 PM

what this feature generates is
<!-Proxy settings works only with a JDK 1.2 and higher.->

<setproxy proxyport="8080" proxyhost="proxy.toto.com">
</setproxy>

with the values of my proxy settings.

I would prefer to have references to the properties this settings were set from:
<setproxy proxyport="${maven.proxy.port}" proxyhost="${maven.proxy.host}">
</setproxy>

Because usually when you generate a build.xml it is for others, not for you.


Arnaud Heritier added a comment - 30/Jul/04 03:59 PM

I agree with you.
But the question is : can we consider to use maven properties in an Ant script?
Shouldn't we use separate properties (ant.proxy...) ??


dion gillard added a comment - 30/Jul/04 11:12 PM

It makes sense to use the maven properties, IMHO


Arnaud Heritier added a comment - 31/Jul/04 05:22 AM

Ok. I'll modify it.


Arnaud Heritier added a comment - 31/Jul/04 05:23 AM

We must replace the value of the maven properties by the maven properties themself.


Arnaud Heritier added a comment - 16/Aug/04 09:19 AM

Will be fixed in 1.8.1


Arnaud Heritier added a comment - 16/Aug/04 05:41 PM

I have a problem to resolve this issue.
The properties proxyuser and proxypassword are available only in ant 1.6.
So, is it annoying if the generated scripts are usable only with ant 1.6 ?


Arnaud Heritier added a comment - 26/Feb/05 07:37 PM

A new property maven.ant.compatibility is available if the user wants to generate a script compatible with ant 1.5.