Maven 1.x Announcement Plugin

xml entities transformed in wrong direction

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3
  • Fix Version/s: 1.4
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

If changes.xml contains & for example, in the announcement it should be & but is &

IE, the entity should be evaluated, not escaped.

Activity

Hide
Vincent Massol added a comment -

Any idea on how to solve this?

Show
Vincent Massol added a comment - Any idea on how to solve this?
Hide
Arnaud Heritier added a comment -

Isn't it the same problem than in the xdoc plugin when we used entities in links ?

Show
Arnaud Heritier added a comment - Isn't it the same problem than in the xdoc plugin when we used entities in links ?
Hide
Brett Porter added a comment -

To be honest, I haven't looked.

I don't think it is the same as xdoc, because announcement wouldn't be using jelly:xml, would it?

Show
Brett Porter added a comment - To be honest, I haven't looked. I don't think it is the same as xdoc, because announcement wouldn't be using jelly:xml, would it?
Hide
Vincent Massol added a comment -

Brett, here is the code in the announcement plugin that produces the printed text:

<x:set var="body" select="string(.)"/>
[...]

<j:set var="text" trim="true">
${body}
[...]
</j:set>

<j:forEach var="line" items="${formatter.format(text,75)}">
[...]
<j:whitespace trim="false">
o ${line}</j:whitespace>
[...]

Do you have any idea on how to fix the ampersand issue?

You mentioned in an email something about the xdoc plugin having something similar. Can you expand?

Thanks

Show
Vincent Massol added a comment - Brett, here is the code in the announcement plugin that produces the printed text: <x:set var="body" select="string(.)"/> [...] <j:set var="text" trim="true"> ${body} [...] </j:set> <j:forEach var="line" items="${formatter.format(text,75)}"> [...] <j:whitespace trim="false"> o ${line}</j:whitespace> [...] Do you have any idea on how to fix the ampersand issue? You mentioned in an email something about the xdoc plugin having something similar. Can you expand? Thanks
Hide
Lukas Theussl added a comment -

I don't know how to evaluate entities in jelly, so I hacked around this by replacing the escaped entities by hand after the transform. If somebody knows a better way, please let me know.

Show
Lukas Theussl added a comment - I don't know how to evaluate entities in jelly, so I hacked around this by replacing the escaped entities by hand after the transform. If somebody knows a better way, please let me know.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: