Maven 1.x Announcement Plugin

make announcement plugin usable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1
  • Component/s: None
  • Labels:
    None
  • Environment:
    announcement plugin 1.0
  • Number of attachments :
    1

Description

actually announcements produced by the plugin are poor and usable only for maven-plugins projects:

  • the first line is hardcoded to: "the maven team is pleased..."
  • the download links only points to ibiblio
  • the comment "this plugin has only been tested with maven... TODO ..." is always added

This patch fixes:

  • the team name is taken from pom.groupId
  • [] are removed from the first line (this was a todo in the file)
  • changes are sorted by type
  • changes report issue number and due-to (this was a TODO)
  • the download link is generated from pom.distributionDirectory
  • the "plugin has been tested with..." line has been removed (also note it was incomplete, maven version was a TODO)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
fabrizio giustina added a comment -

announcement.jsl diff

Show
fabrizio giustina added a comment - announcement.jsl diff
Hide
Permalink
Vincent Massol added a comment -

Hi Fabrizio,

Thanks for your patch! I've applied it on my machine and I'm ready to commit it. However, I've tried to run it on the announcement plugin itself and I've noticed several strange behaviors:

  • Maven doesn't display any goal executing:

E:\Dev\maven-plugins\announcement>maven announcement
__ __

\/ __ Apache_ ___
  \/ / ` \ V / -) ' \ ~ intelligent projects ~
_   _,_ _/___ _ _ v. 1.0-rc3-SNAPSHOT

Plugin cache will be regenerated
BUILD SUCCESSFUL
Total time: 8 seconds
Finished at: Mon Apr 12 21:15:43 CEST 2004

E:\Dev\maven-plugins\announcement>

  • It fails to generate the announcement.txt file. Or rather it does generate it but it's empty.

Any idea?

Thanks

Show
Vincent Massol added a comment - Hi Fabrizio, Thanks for your patch! I've applied it on my machine and I'm ready to commit it. However, I've tried to run it on the announcement plugin itself and I've noticed several strange behaviors:
  • Maven doesn't display any goal executing:
E:\Dev\maven-plugins\announcement>maven announcement __ __
\/ __ Apache_ ___
  \/ / ` \ V / -) ' \ ~ intelligent projects ~
_   _,_ _/___ _ _ v. 1.0-rc3-SNAPSHOT
Plugin cache will be regenerated BUILD SUCCESSFUL Total time: 8 seconds Finished at: Mon Apr 12 21:15:43 CEST 2004 E:\Dev\maven-plugins\announcement>
  • It fails to generate the announcement.txt file. Or rather it does generate it but it's empty.
Any idea? Thanks
Hide
Permalink
Vincent Massol added a comment -

Correction. It works. I had simply not set the maven.announcement.version property...

However, there are no goals displayed but that's another problem. I'll commit your patch in a few minutes.

Show
Vincent Massol added a comment - Correction. It works. I had simply not set the maven.announcement.version property... However, there are no goals displayed but that's another problem. I'll commit your patch in a few minutes.
Hide
Permalink
Vincent Massol added a comment -

Applied patch. I'll open another issue for the other problem.

Show
Vincent Massol added a comment - Applied patch. I'll open another issue for the other problem.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
5m
Original Estimate - 5 minutes
Remaining:
5m
Remaining Estimate - 5 minutes
Logged:
Not Specified
Time Spent - Not Specified
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.