|
Sort Order:
Carlos Sanchez made changes - 01/May/07 04:13 PM
Carlos Sanchez made changes - 01/May/07 04:13 PM
Carlos Sanchez made changes - 01/May/07 04:13 PM
Cleaned up patch and updated to current svn version
Carlos Sanchez made changes - 01/May/07 05:23 PM
Carlos Sanchez made changes - 01/May/07 05:33 PM
Carlos Sanchez made changes - 01/May/07 05:33 PM
for some reason the xml files show up as completely changed in the patch although only the first line changes With this patch I get this error This is the error i'm getting now $ mvn docbook:transform -e It looks like the incorrect URL resolver is used. I will take a look at your changes later. Lars, do you have a timeframe for when you might be able to look at this? Carlos has been trying to get this working on Acegi Security (which is trying to migrate to Maven 2) for a long time now and has provided a number of patches. This one issue supersedes all prior issues for the DocBook plugin, and there is no viable alternative Maven 2 DocBook plugin, so this issue does seem to be well-worth the investment to get working and into a formal release. Ben, I am currently very much involved with a deadline in another open source project, so I can promise that I will not be able to look into this prior to June, 21, but will as soon as possible after the release. I just looked into the issue and found the cause of the problem: Carlos changed the dependencies of the plugin to use the version of the DocBook-XSL-Stylesheets that is available in the repository, which is packaged as a ZIP file. The MojoURIResolver provided with my patch loads resource:// urls from classpath resources, and the default configuration expects a JAR file containing the docbook-xsl stylesheets as seen on http://releases.mindquarry.org/org/docbook/docbook-xsl/1.72.0/ My patch reverts some of Carlos' changes to the depdendency management:
Lars Trieloff made changes - 07/Jun/07 03:42 PM
your patch says revision 3044, latest is 4022 Looks like I added the wrong patch file. It looks like a proper version of FOP is already available in the repository, so the only missing dependency is the docbook-xsl.jar
Lars Trieloff made changes - 08/Jun/07 01:48 AM
What are the chances of getting this patch applied? I would like to contribute some further patches building upon this like support for chunked HTML output, for text output and an option to use non PDF-native fonts. the chances depend a lot on you, I have most of it applied, but
Now I'm getting a MalformedURLException (I was playing with the resource:// values but I don't think that matters) java.lang.RuntimeException: Unable to get a transformer instance from source resource://net/xhtml/docbook.xsl if you add the license headers in a new patch I think it's ready to be committed if you later look at the error Thank you. I will have a look tomorrow. Hm, this repackaging means the URL should be resource:// (because everything is then below, e.g. html/docbook.xsl) But this is no valid URL. New patch,
Lars Trieloff made changes - 25/Jun/07 09:35 AM
Finally, I got it working. There have been some changes however: 1. The URL pattern is now resource://groupId/artifactId/pathInJarFile
Lars Trieloff made changes - 25/Jun/07 01:50 PM
Patch has been commited, now if I run docbook:transform in the pluign I get this exception Make sure you use the artifacts in the central repo and not the ones in your repo [INFO] Scanning for projects... Does your configuration contain references to resource://net/xhtml/docbook.xsl ? I am using only resources from the public maven repository. The correct docbook dependency is: <dependency> It does not look like you applied the correct patch, as my latest patch contains following lines: @parameter expression="${stylesheetLocation}"
while the current svn code contains resource://net which is incorrect I'm running it in the plugin folder, with the latest in SVN, you can see the configuration there The dependency used is dockbook packed as jar as you suggested <dependency> Please use the older docbook dependency (packaged as a ZIP file, the updated plugin can handle this) as the newer docbook stylesheets come with And I still think you did not apply the right patch, as TransformMojo.java still contains the wrong default configuration. I had the previous patch ready, now applied the differences in the last one, I think this is ready now
Carlos Sanchez made changes - 25/Jun/07 05:07 PM
Thank you. Expect no updates earlier than tomorrow. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Closed
Major
DocBook Profiling Support
I have spent a lot of time with this patch, cleaning up, complete changes formats, missing dependencies and all kinds of problems
It is a really bad idea to put together such massive amount of changes