Mojo

native-maven-plugin no stale check at linkage

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: native
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

As of 1.0-alpha-7, native plugin does relink all the time. Though it takes not too much time, it would be better to avoid it.

Attached is the patch that checks for linker input stale state and skips accordingly. Across two components - maven-native-api && native-maven-plugin.

  1. Text File
    maven-native-api2.patch
    14/Dec/11 3:53 PM
    3 kB
    Sergey Grashchenko
  2. Text File
    native-maven-plugin2.patch
    14/Dec/11 3:53 PM
    3 kB
    Sergey Grashchenko

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Tran added a comment -

would be nice to see an integration test for this. Thanks

Show
Dan Tran added a comment - would be nice to see an integration test for this. Thanks
Hide
Permalink
Dan Tran added a comment -

also, the patch does not follow the coding convention. If you are using eclispe you can use the code formatter specifier under maven-native/pom.xml

Show
Dan Tran added a comment - also, the patch does not follow the coding convention. If you are using eclispe you can use the code formatter specifier under maven-native/pom.xml
Hide
Permalink
Sergey Grashchenko added a comment - - edited

> also, the patch does not follow the coding convention.
Ok, I'll send an update a bit later.

> would be nice to see an integration test for this.

In fact, I'm not sure how can I provide it now. I've been testing it "by hand" on a real project, meaning I've been running "mvn compile" in there and checking if it does relink if nothing changed or not and if it does it if smth changed.

It could look a bit complicated 'coz we have also abstraction model in 4 levels to enable generalization of cppProject for linux/windows and static/dynamic libraries/executables.

Would you like to take a look at the project?

Show
Sergey Grashchenko added a comment - - edited > also, the patch does not follow the coding convention. Ok, I'll send an update a bit later. > would be nice to see an integration test for this. In fact, I'm not sure how can I provide it now. I've been testing it "by hand" on a real project, meaning I've been running "mvn compile" in there and checking if it does relink if nothing changed or not and if it does it if smth changed. It could look a bit complicated 'coz we have also abstraction model in 4 levels to enable generalization of cppProject for linux/windows and static/dynamic libraries/executables. Would you like to take a look at the project?
Hide
Permalink
Sergey Grashchenko added a comment -

Restyled with Eclipse using http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/optional/eclipse-config/maven-styles.xml

Show
Sergey Grashchenko added a comment - Restyled with Eclipse using http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/optional/eclipse-config/maven-styles.xml

People

  • Assignee:
    Dan Tran
    Reporter:
    Sergey Grashchenko
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: