Mojo

BanDuplicateClasses should skip any artifacts not of type jar

Details

  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

In MOJO-1731, BanDuplicateClasses was modified to skip artifacts of type pom. However, it really only makes sense to process jars. war, ear and rar artifacts might be openable as jars, but there is no real point, since classes are not located at the top level. More troublesome are other (non-standard) artifact types such as rpm.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ian Robertson added a comment -

Patch attached.

Show
Ian Robertson added a comment - Patch attached.
Ian Robertson made changes -
Field Original Value New Value
Attachment mojo-1775.patch [ 57589 ]
Robert Scholte made changes -
Summary BanDuplciateClasses should skip any artifacts not of type jar BanDuplicateClasses should skip any artifacts not of type jar
Hide
Permalink
Robert Scholte added a comment -

I'm wondering if this counts for wars too, since you can have overlays with clashing classes.

Show
Robert Scholte added a comment - I'm wondering if this counts for wars too, since you can have overlays with clashing classes.
Hide
Permalink
Ian Robertson added a comment -

If we want to process wars, then we should process them properly: look in WEB-INF/classes, as well as in each of the jars in WEB-INF/lib.

Show
Ian Robertson added a comment - If we want to process wars, then we should process them properly: look in WEB-INF/classes, as well as in each of the jars in WEB-INF/lib.
Baptiste Mathus made changes -
Assignee Baptiste Mathus [ baptiste ]
Hide
Permalink
Baptiste Mathus added a comment -

I agree that processing war would a different beast. I think that the attached patch seems quite sensible, only processing things we know how to process instead of excluding just one we know we can't.

Show
Baptiste Mathus added a comment - I agree that processing war would a different beast. I think that the attached patch seems quite sensible, only processing things we know how to process instead of excluding just one we know we can't.
Hide
Permalink
Baptiste Mathus added a comment -

Fixed in revision 18000.

Show
Baptiste Mathus added a comment - Fixed in revision 18000 .
Baptiste Mathus made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s extra-enforcer-rules-1.0-alpha-4 [ 18450 ]
Resolution Fixed [ 1 ]

People

  • Assignee:
    Baptiste Mathus
    Reporter:
    Ian Robertson
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: