Link command too long on Windows

Dan Tran added a comment - 02/Mar/11 12:24 PM Please provide a 'svn diff' format. Thank you for looking into this issue

Jean-Marie Dautelle added a comment - 03/Mar/11 8:40 AM - edited # This patch file was generated by NetBeans IDE # It uses platform neutral UTF-8 encoding and \n newlines. --- Base (BASE) +++ Locally Modified (Based On LOCAL) @@ -24,6 +24,7 @@ * SOFTWARE. */ +import java.io.IOException; import org.codehaus.mojo.natives.NativeBuildException; import org.codehaus.mojo.natives.linker.AbstractLinker; import org.codehaus.mojo.natives.linker.LinkerConfiguration; @@ -32,8 +33,10 @@ import org.codehaus.plexus.util.cli.Commandline; import java.io.File; +import java.io.FileWriter; import java.util.Iterator; import java.util.List; +import org.codehaus.plexus.util.Os; /** * Generic C/CPP linker with "-o " as its output option @@ -76,15 +79,42 @@ cl.createArg().setValue( linkerOutputOption + config.getOutputFile() ); } + // On windows to avoid command lines too long we have to use a linker response file. + if ( ( objectFiles.size() > 32 ) && ( Os.isFamily( Os.FAMILY_WINDOWS ) || Os.isFamily( Os.FAMILY_WIN9X ) ) ) + { + try + { + File linkerFile = new File( config.getWorkingDirectory().getPath(), "objectsFile" ); + FileWriter linkerFileWriter = new FileWriter( linkerFile, false /* Don't append */); for ( int i = 0; i < objectFiles.size(); ++i ) { - File objFile = (File) objectFiles.get( i ); + File objFile = ( File ) objectFiles.get( i ); + // Shorten the command line. + String objFilePath = FileUtil.truncatePath( objFile.getPath(), config.getWorkingDirectory().getPath() ); + linkerFileWriter.write(objFilePath + "\n"); + } + linkerFileWriter.close(); + } + catch ( IOException error ) + { + throw new NativeBuildException( "Error creating linker response file", error); + } + cl.createArg().setValue("@objectsFile"); + } + else + { // Normal behavior. + + for ( int i = 0; i < objectFiles.size(); ++i ) + { + File objFile = ( File ) objectFiles.get( i ); + //we need to shorten the command line since windows has limited command line length String objFilePath = FileUtil.truncatePath( objFile.getPath(), config.getWorkingDirectory().getPath() ); cl.createArg().setValue( objFilePath ); } + } if ( config.getMiddleOptions() != null ) {

Dan Tran added a comment - 05/Mar/11 7:37 PM Enhance the patch + add test to allow option to use linker response file to resolve windows command line size limitation fixed at revision 13690.