Mojo

EclipseMojo creates factory path entries with trailing whitespace

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: apt-maven-plugin-1.0-alpha-4
  • Fix Version/s: apt-maven-plugin-1.0-alpha-5
  • Component/s: apt
  • Labels:
    None
  • Environment:
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Invoking mvn apt:eclipse creates a .factorypath file with entries that contain trailing whitespaces:

<factorypath> 
    <factorypathentry kind="EXTJAR" id="/Users/tfnico/projects/apt-maven-plugin-testing/target/classes " enabled="true" runInBatchMode="false"/>
    <factorypathentry kind="VARJAR" id="M2_REPO/junit/junit/3.8.1/junit-3.8.1.jar " enabled="true" runInBatchMode="false"/>
</factorypath>

Easy to recreate: mvn archetype:generate a new simple project with default values. Edit the pom.xml, make junit compile scope, paste in the apt-maven-plugin config, run mvn apt:eclipse.

Recreated this in trunk of the plugin (r13275). The problem is caused by a tiny typo in the EclipseMojo. Attached a patch that resolves it, at least on my system.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas Ferris Nicolaisen added a comment -

Oh, and by the way, maybe this should be another bug-report, but I'll just paste it in here:

apt:eclipse generates a path for "Generated source directory" with a leading slash that Eclipse won't grok. For example:

<outputDirectory>src-generated</outputDirectory>

.. produces this configuration directory:

org.eclipse.jdt.apt.genSrcDir=/src-generated

..resulting in that Eclipse won't do annotation processing.

I quickfixed it by just substringing away the slash in the EclipseMojo.java, but maybe you've got some ideas for a better solution..

Show
Thomas Ferris Nicolaisen added a comment - Oh, and by the way, maybe this should be another bug-report, but I'll just paste it in here: apt:eclipse generates a path for "Generated source directory" with a leading slash that Eclipse won't grok. For example: <outputDirectory>src-generated</outputDirectory> .. produces this configuration directory: org.eclipse.jdt.apt.genSrcDir=/src-generated ..resulting in that Eclipse won't do annotation processing. I quickfixed it by just substringing away the slash in the EclipseMojo.java, but maybe you've got some ideas for a better solution..
Hide
Permalink
Mark Hobson added a comment -

Patched applied in r14641, thanks.

Please open a separate issue for the other problem.

Show
Mark Hobson added a comment - Patched applied in r14641, thanks. Please open a separate issue for the other problem.

People

  • Assignee:
    Mark Hobson
    Reporter:
    Thomas Ferris Nicolaisen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: