Mojo
  1. Mojo
  2. MOJO-1204

In Maven 1 style dashboard reports: summarize the report data per module

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: dashboard
    • Labels:
      None
    • Environment:
      any
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      5

      Description

      The attached patch

      1) prints "N/A" in cells when no report data is available
      2) prints a "Total for $component" summary line for each component in multi module builds
      3) does not print any "Total" summary line for single module builds
      (it seems unnecessary to me why you should summarize a single line - that is just duplication of information)

      1. patch.txt
        8 kB
        Michael
      1. multi_module_project.png
        25 kB
      2. multi-module_patch.png
        94 kB
      3. new_multi_module_project.png
        28 kB
      4. single_module_project.png
        12 kB

        Activity

        Hide
        David Vicente added a comment -

        See these screenshoots.

        does this suit your needs?

        Show
        David Vicente added a comment - See these screenshoots. does this suit your needs?
        Hide
        Michael added a comment -

        David:

        thanks for your work. This greatly improves the report.

        I have attached the screenshot "multi-module_patch.png" which shows how the report looks like with the patch I attached. We build a multi module build "components" which includes three modules (runtime, admin and another one), where runtime has another sub-module "extensions".

        You may notice that the summary lines are in different color than the report lines.

        I think it would be an improvement in your modifications if you would change the background color of the summary line, as it is otherwise not possible to distinguish between data and summary rows if you scroll to the right or have a quick look at the report: it is rather clumsy to figure out what entry is a sum (and hence doesn't "count") and what is real data.

        Have you included the "N/A" patch in your modifications? I just ask because this is not clear in the screenshot you attached.

        Show
        Michael added a comment - David: thanks for your work. This greatly improves the report. I have attached the screenshot "multi-module_patch.png" which shows how the report looks like with the patch I attached. We build a multi module build "components" which includes three modules (runtime, admin and another one), where runtime has another sub-module "extensions". You may notice that the summary lines are in different color than the report lines. I think it would be an improvement in your modifications if you would change the background color of the summary line, as it is otherwise not possible to distinguish between data and summary rows if you scroll to the right or have a quick look at the report: it is rather clumsy to figure out what entry is a sum (and hence doesn't "count") and what is real data. Have you included the "N/A" patch in your modifications? I just ask because this is not clear in the screenshot you attached.
        Hide
        Michael added a comment -

        Maven 1 style dashboard with summary lines (as created with the attached patch).

        Show
        Michael added a comment - Maven 1 style dashboard with summary lines (as created with the attached patch).
        Hide
        David Vicente added a comment - - edited

        see the " new_multi_module_project.png" screenshot and give me your review

        Show
        David Vicente added a comment - - edited see the " new_multi_module_project.png" screenshot and give me your review
        Hide
        Michael added a comment -

        David:

        This looks fine.

        In you screen shot, I'm missing the "N/A" tag for surefire, and the coloring seems not yet to be implemented for checkstyle. However, it seems to be a good approach!

        Please let me know when these changes are available in SCM and in what branch I can find them. I'd like to test the modifications in our local build.

        Show
        Michael added a comment - David: This looks fine. In you screen shot, I'm missing the "N/A" tag for surefire, and the coloring seems not yet to be implemented for checkstyle. However, it seems to be a good approach! Please let me know when these changes are available in SCM and in what branch I can find them. I'd like to test the modifications in our local build.
        Hide
        Karl-Heinz Marbaise added a comment -

        Closing, cause Maven 1 has been buried.

        Show
        Karl-Heinz Marbaise added a comment - Closing, cause Maven 1 has been buried.

          People

          • Assignee:
            Karl-Heinz Marbaise
            Reporter:
            Michael
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: