Issue Details (XML | Word | Printable)

Key: MOJO-1033
Type: Improvement Improvement
Status: Closed Closed
Resolution: Cannot Reproduce
Priority: Major Major
Assignee: David Vicente
Reporter: Venelin Mitov
Votes: 2
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Mojo

Add a new parameter to avoid "loosing the history" after changing a project's version

Created: 01/Feb/08 07:56 AM   Updated: 08/Apr/08 07:27 AM
Component/s: dashboard
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. surefire_currentdaypartenaire_Histo_Surefire.png
(27 kB)
Issue Links:
dependent
 

Complexity: Intermediate


 Description  « Hide
Hello,

The histrorical charts for a project are empty every time the version of a project changes.
Is it possible to avoid "loosing the history" in the maven-dashboard-report after changing the project version? It would be great to display in the same chart how the quality of the project code evolves between different project releases. To keep the current functionality and configuration intact it might be the best to add a configuration parameter say:

excludeVersionFromProjectId - default = false - Set to true if the historical dashboard should contain information from different project versions. Otherwise the historical charts for a project will be empty each time the project's version changes.

Best regards,
Venelin



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
David Vicente added a comment - 13/Feb/08 04:24 PM
Hi,

The <keepVersionAsDiscriminantCriteria> parameter will be used to keep the version as a discriminant criteria of a project.

If set as "true", the data of reports will be specific to this version of a project.

If set as "false", the data of reports will be associated with the project regardless of its version.

By default, the <keepVersionAsDiscriminantCriteria> parameter will be set to "true"

Best regards

David


David Vicente added a comment - 10/Mar/08 03:34 PM
ok

deployed as new snpahot version dashboard-maven-plugin-1.0-20080310.203128-18.jar


Odin Standal added a comment - 12/Mar/08 04:23 AM
I tested the new snapshot, and found that it works when new data was added. However, my old data is not incorporated correctly when the version has changed. Thus I would request that the issue is reopened. It would be an improvement if the data saving part is kept the same as before, and only change the query for data . This way, you could easily switch between the two modes (keepVersionAsDiscriminant = true or false) without having to change the data.

David Vicente added a comment - 12/Mar/08 04:37 AM
As Odin Standal added a comment, i reopen this issue to take account his approach

David Vicente added a comment - 21/Mar/08 10:06 AM
The new parameter "keepVersionAsDiscriminantCriteria" will work at querying data and no at storing data as Odin Standal's proposition and help

David Vicente added a comment - 05/Apr/08 01:27 PM
desployed the 2008-04-05 as 1.0-SNAPSHOT ( dashboard-maven-plugin-1.0-20080405.182352-19.jar)

Venelin Mitov added a comment - 07/Apr/08 09:39 AM
Hello,

Thanks for adding the new parameter. Displaying the progress between different project versions on the same chart is exactly what I needed.

I have only one remark: The history for previous versions still misses in the dashboard of a multimodule project. In my organization we have all internally developed modules of an application developed under the same svn directory. For example:

svn/trunk/MyApplication:
MyApplicationEJBClient
MyApplicationEJB
MyApplicationSecurityManager
...
MyApplicationEAR

And by convention all those projects including the parent one (the pom.xml file directly under the svn/trunk/MyApplication directory) have the same version number which changes between different releases.

Is it possible to have the history of different versions of the parent project in the same chart?

Best regards,
Venelin


David Vicente added a comment - 07/Apr/08 09:57 AM
HI,

i don't understand your request.

If you configure the dashboard in pom.xml of svn/trunk/MyApplication project and add each application as sub-module of this

you can make at root level (svn/trunk/MyApplication) :

  • mvn site
  • mvn dashboard-report:persist
  • mvn dashboard-report:dashboard

and for the parent and each sub-module, you have an historic report with version progress ?


Venelin Mitov added a comment - 08/Apr/08 05:03 AM
Overlapping version numbers on the historical chart.

Venelin Mitov added a comment - 08/Apr/08 05:25 AM
Hi David,

Sorry. Maybe I've made an error yesterday while generating the historical dashboard. But now the historical dashboard for th parent project looks fine. I attached the surefire historical chart for one of my the parent projects.

P.S. Maybe, one possible improvement would be to vary the level on which the version numbers are displayed to avoid that they overlap.

Something like:

I........................................................I Version 1.0..........................I Version 1.1
I Version 1.0-SNAPSHOT...........II Version 1.1-SNAPSHOT..II Version 1.2-SNAPSHOT

Or maybe you would have a better idea.

Anyway, I am happy with the historical charts as they are displayed now, because I can see the project evolution between different releases.

Best thanks,
Venelin


David Vicente added a comment - 08/Apr/08 07:27 AM
Hi Venelin,

i'm happy to see that it works fine for you.

For the label marker overlapping, i'm working on it. It's not beautiful )