Modello

Major modello-plugin-xdoc rewrite

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-11
  • Fix Version/s: 1.0-alpha-18
  • Component/s: modello-plugin-xdoc
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    2

Description

Following MODELLO-53 and MODELLO-54 I did a major rewrite of the XdocGenerator.

This include the points raised by Vincent in the 2 previous issues.

Now, the plugin can neatly generate things like the doxia-descriptor-model, with full support for attributes, listStyle and recursion in models.
It can as well handle different tags, given the same tagName but different backing classes (as MenuItem and LinkItem in doxia model).

I have tested it for backward compatibility with maven-model, and maven-settings and everything looks fine to me.
I have tested with the proposed changes model (see MCHANGES-47 ) and no problem there either.

I haven't been able to test it with assembly model (because of maven 2.0.5-SNAPSHOT ), but these models are failry simple (and close to maven-model).

You can have a look at the generated document there:
http://dcabasson.developpez.com/maven/decoration.html

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Denis Cabasson added a comment -

Here is the patch.

It includes the 2 patches provided by vincent (as some of it has been rewritten). Many thanks to him.

Show
Denis Cabasson added a comment - Here is the patch. It includes the 2 patches provided by vincent (as some of it has been rewritten). Many thanks to him.
Hide
Permalink
Denis Cabasson added a comment -

Having gained some insights since the last time, here is a cleaner version of the code (with updated javadoc).

Most of the helper methods (not to say all of them) should be promoted to a helper class, probably in modello-plugin-xml.

Show
Denis Cabasson added a comment - Having gained some insights since the last time, here is a cleaner version of the code (with updated javadoc). Most of the helper methods (not to say all of them) should be promoted to a helper class, probably in modello-plugin-xml.
Hide
Permalink
Dennis Lundberg added a comment -

I have applied Vincent's patches for MODELLO-53 and MODELLO-54. Now I'm having trouble applying your patch. Do you think that you could create a new patch file based on the current SVN content?

Show
Dennis Lundberg added a comment - I have applied Vincent's patches for MODELLO-53 and MODELLO-54 . Now I'm having trouble applying your patch. Do you think that you could create a new patch file based on the current SVN content?
Hide
Permalink
Herve Boutemy added a comment -

The patch did not apply, and contained both refactorings and bugfixes
then I picked the refactorings ideas only
For the bugfixes, please open other Jira issues

Show
Herve Boutemy added a comment - The patch did not apply, and contained both refactorings and bugfixes then I picked the refactorings ideas only For the bugfixes, please open other Jira issues

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Denis Cabasson
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: