Modello

Support for xml.attribute and xml.listStyle="flat" is missing in xsd plugin

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-5
  • Fix Version/s: 1.0-alpha-18
  • Component/s: modello-plugin-xsd
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

Problem is trickier here (than for xdoc plugin).

Indeed, attributes are ok, but flat lists are a pain.

Right now, plugin is generating xs:all elements, which doesn't allow for maxOccurs. So that would mean detecting from parent class when child association is flat list, and generating a xs:sequence instead of the xs:all for this element.

Is this solution acceptable?

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. DOXIASITETOOLS-1 Provide a schema for site.xml

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. DOXIA-136 Create an FML DTD or XSD

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Denis Cabasson added a comment -

Support for attributes as well as different xml.listStyle.

Added support for nameSpace, but something is broken in model metadata, see MODELLO-46 .

Some TODOs left in the code.

Don't know if classes such as List or Properties are still supported in modello-core.

And dates doesn't seem to be supported in xsd plugin (update of the test case would be indeed cery interesting on this point).

Show
Denis Cabasson added a comment - Support for attributes as well as different xml.listStyle. Added support for nameSpace, but something is broken in model metadata, see MODELLO-46 . Some TODOs left in the code. Don't know if classes such as List or Properties are still supported in modello-core. And dates doesn't seem to be supported in xsd plugin (update of the test case would be indeed cery interesting on this point).
Denis Cabasson made changes -
Field Original Value New Value
Attachment MODELLO-49-modello-plugin-xsd.patch [ 22101 ]
Dennis Lundberg made changes -
Patch attached Yes
Hide
Permalink
Joakim Erdfelt added a comment -

Support for Date and long was added to the xsd plugin r826.

Support for Model Metadata in core was added in r821.

Support for configurable Namespace was added in r826.

What's left?

Show
Joakim Erdfelt added a comment - Support for Date and long was added to the xsd plugin r826. Support for Model Metadata in core was added in r821. Support for configurable Namespace was added in r826. What's left?
Herve Boutemy made changes -
Link This issue is depended upon by DOXIA-136 [ DOXIA-136 ]
Herve Boutemy made changes -
Assignee Herve Boutemy [ hboutemy ]
Hide
Permalink
Herve Boutemy added a comment -

Support for xml.attribute was just added in r864.

The last one missing is support for xml.listStyle="flat"

Show
Herve Boutemy added a comment - Support for xml.attribute was just added in r864. The last one missing is support for xml.listStyle="flat"
Hide
Permalink
Herve Boutemy added a comment -

added support for xml.listStyle="flat" in r865
since such a list can't be expressed in XML Schema with an "all" compositor, which is the default compositor used, I added an attribute in the Modello class descriptor: xsd.compositor="all|sequence" (default value is "all", of course)
When a class contains a flat list, xsd.compositor="sequence" has to be declared in its descriptor or you'll get an IllegalStateException.
This way, the change from all to sequence is not automagic but known from the developer: when you have a sequence, the order of elements is checked while it is not the case with "all" compositor.
By the way, it permits to choose a sequence even if there is no flat list: after all, this can be a useful feature

Show
Herve Boutemy added a comment - added support for xml.listStyle="flat" in r865 since such a list can't be expressed in XML Schema with an "all" compositor, which is the default compositor used, I added an attribute in the Modello class descriptor: xsd.compositor="all|sequence" (default value is "all", of course) When a class contains a flat list, xsd.compositor="sequence" has to be declared in its descriptor or you'll get an IllegalStateException. This way, the change from all to sequence is not automagic but known from the developer: when you have a sequence, the order of elements is checked while it is not the case with "all" compositor. By the way, it permits to choose a sequence even if there is no flat list: after all, this can be a useful feature
Herve Boutemy made changes -
Fix Version/s 1.0-alpha-18 [ 13717 ]
Status Open [ 1 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Herve Boutemy made changes -
Link This issue is depended upon by DOXIASITETOOLS-1 [ DOXIASITETOOLS-1 ]

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Denis Cabasson
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: