Modello

java5 associations do not respect java.useInterface

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Component/s: modello-plugin-java
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

Modello does not consistently use java.useInterface when generating getter/setter methods for association fields, which becomes more apparent in java5 mode. For example, the following association 

        <field>
          <name>entries</name>
          <association java.useInterface="IEntry">
            <type>Entry</type>
            <multiplicity>*</multiplicity>
          </association>
        </field>

will result in the following method signatures in java5 mode

public void addEntry( IEntry entry )
public java.util.List<Entry> getEntries()
public void removeEntry( IEntry entry )
public void setEntries( java.util.List<Entry> entries )

Note incorrect type parameter java.util.List<Entry> instead of expected java.util.List<IEntry>

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MODELLO-120 can't have an association to an interface instead of a class

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Fedorenko added a comment -

Attached patch MODELLO-222.diff addresses the problem at least partially. More specifically,

  • only simple one-to-many association was tested and other associations likely still have this problem
  • association default value is ignored, which may or may not be a problem
  • generation of clone method was not tested and may or may not have this problem

Unfortunately, I do not know about modello enough to assess whether these are real problems and would appreciate if somebody with the knowledge reviewed the code and provided feedback. Thank you in advance.

Show
Igor Fedorenko added a comment - Attached patch MODELLO-222 .diff addresses the problem at least partially. More specifically, only simple one-to-many association was tested and other associations likely still have this problem association default value is ignored, which may or may not be a problem generation of clone method was not tested and may or may not have this problem Unfortunately, I do not know about modello enough to assess whether these are real problems and would appreciate if somebody with the knowledge reviewed the code and provided feedback. Thank you in advance.
Hide
Permalink
Igor Fedorenko added a comment -

I committed the patch. Let me know if there are any concerns.

Show
Igor Fedorenko added a comment - I committed the patch. Let me know if there are any concerns.
Hide
Permalink
Herve Boutemy added a comment -

just added a test to confirm that one multiplicity association fails
didn't try clone method

I'm still closing this issue since the actual behaviour is better than before, even if not completely feature complete: work on other will be done later when somebody needs it

thank you Igor

Show
Herve Boutemy added a comment - just added a test to confirm that one multiplicity association fails didn't try clone method I'm still closing this issue since the actual behaviour is better than before, even if not completely feature complete: work on other will be done later when somebody needs it thank you Igor
Hide
Permalink
Herve Boutemy added a comment -

while thinking at it, one other part that is not tested: createTypeAssociation() and breakTypeAssociation() (see java.bidi)
not so frequently used, os like my previous comment "work will be done later when somebody needs it"

Show
Herve Boutemy added a comment - while thinking at it, one other part that is not tested: createTypeAssociation() and breakTypeAssociation() (see java.bidi) not so frequently used, os like my previous comment "work will be done later when somebody needs it"

People

  • Assignee:
    Igor Fedorenko
    Reporter:
    Igor Fedorenko
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: