Strict mode does not detect problems when data fields are encoded as XML attributes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.2
  • Component/s: modello-plugin-xpp3
  • Labels:
    None
  • Complexity:
    Intermediate

Description

For fields with xml.attribute="true" the generated parser does not throw a validation error when a required attribute is missing nor when an unknown attribute is present. Run "mvn test" on the attached demo project for an illustration.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MODELLO-227 Strict mode does not detect problems when data fields are encoded as XML attributes

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Bug - A problem which impairs or prevents the functions of the product. MODELLO-44 Modello XPP3 Reader does not honor <required>true</required> in model.

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.
relates to

Bug - A problem which impairs or prevents the functions of the product. MODELLO-225 "required" field descriptor not honoured

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Herve Boutemy added a comment -

I just made strict parsing fail for invalid attributes in r1326

for required attributes, the problem is wider than attributes: I just had a look and discovered that nothing was done with required fields in any plugin, either elements or attributes, then opened MODELLO-225 to track this issue

Show
Herve Boutemy added a comment - I just made strict parsing fail for invalid attributes in r1326 for required attributes, the problem is wider than attributes: I just had a look and discovered that nothing was done with required fields in any plugin, either elements or attributes, then opened MODELLO-225 to track this issue
Hide
Permalink
Herve Boutemy added a comment -

added strictXmlAttributes model default value (true by default) in r1351 to be able to disable strict XML attributes checking

Show
Herve Boutemy added a comment - added strictXmlAttributes model default value (true by default) in r1351 to be able to disable strict XML attributes checking

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: