Maven Project Web Site
  1. Maven Project Web Site
  2. MNGSITE-152

Maven websites don't follow ASF rules on License

    Details

    • Type: Bug Bug
    • Status: Reopened Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Labels:
      None
    • Number of attachments :
      1

      Description

      ASF projects are supposed to provide a prominent link [0] to the ASF licenses page [1]

      AIUI, websites are not supposed to provide their own license pages.

      [0] http://apache.org/foundation/marks/pmcs.html#navigation
      [1] http://www.apache.org/licenses/

        Activity

        Hide
        SebbASF added a comment -

        PING

        Show
        SebbASF added a comment - PING
        Hide
        Karl-Heinz Marbaise added a comment -

        The current site states an explicit link license in the upper left navigation ...Is that prominent enought or should be done in a different way? So can this be closed or does need to be left open?

        Show
        Karl-Heinz Marbaise added a comment - The current site states an explicit link license in the upper left navigation ...Is that prominent enought or should be done in a different way? So can this be closed or does need to be left open?
        Hide
        SebbASF added a comment -

        That main Maven website looks good.
        It has the license in the Download section, which is the best place for it (users need to know the license before downloading).

        However, the plugin websites don't currently follow this lead.

        Just checked the Aseembly and Changes Plugins and they bury the license link way down under Project Information as well as linking to a local copy rather than the ASF main site as required.

        Show
        SebbASF added a comment - That main Maven website looks good. It has the license in the Download section, which is the best place for it (users need to know the license before downloading). However, the plugin websites don't currently follow this lead. Just checked the Aseembly and Changes Plugins and they bury the license link way down under Project Information as well as linking to a local copy rather than the ASF main site as required.
        Karl-Heinz Marbaise made changes -
        Field Original Value New Value
        Attachment screenshot-license.png [ 65514 ]
        Karl-Heinz Marbaise made changes -
        Comment [ Screenshot about location for license. ]
        Hide
        Karl-Heinz Marbaise added a comment -

        Ok. I have taken a look would it be sufficient to put a link into the left navigation in the area Overview like the screen shot i've taken and attached to this ticket. Would that fit?

        Show
        Karl-Heinz Marbaise added a comment - Ok. I have taken a look would it be sufficient to put a link into the left navigation in the area Overview like the screen shot i've taken and attached to this ticket. Would that fit?
        Hide
        SebbASF added a comment -

        Yes, that looks fine, assuming that the link points to the ASF license page.

        BTW, if you are doing a general refresh of the plugin websites, they really ought to have links to the source downloads under dist/maven/plugins on the ASF mirror system.

        Show
        SebbASF added a comment - Yes, that looks fine, assuming that the link points to the ASF license page. BTW, if you are doing a general refresh of the plugin websites, they really ought to have links to the source downloads under dist/maven/plugins on the ASF mirror system.
        Hide
        Karl-Heinz Marbaise added a comment -

        Do you mean by downloads the following location:

        https://dist.apache.org/repos/dist/release/maven/plugins/
        ?
        Or how is the ASF mirror system reachable ?

        Show
        Karl-Heinz Marbaise added a comment - Do you mean by downloads the following location: https://dist.apache.org/repos/dist/release/maven/plugins/ ? Or how is the ASF mirror system reachable ?
        Hide
        SebbASF added a comment -

        Have a look at how Maven itself does its download page:
        http://maven.apache.org/download.cgi

        Show
        SebbASF added a comment - Have a look at how Maven itself does its download page: http://maven.apache.org/download.cgi
        Hide
        Karl-Heinz Marbaise added a comment -

        So you mean having every plugin a link to the http://maven.apache.org/download.cgi download page? Did i get it right?

        Show
        Karl-Heinz Marbaise added a comment - So you mean having every plugin a link to the http://maven.apache.org/download.cgi download page? Did i get it right?
        Hide
        SebbASF added a comment -

        The ASF releases source, and projects must provide links to download that source which must be served from the ASF mirror system.

        The http://maven.apache.org/download.cgi download page does that for the Maven product.

        There needs to be a download link for the source to each plugin as well.

        The plugins can share a page, but the main Maven page is already long enough so I don't think their links belong there.

        Show
        SebbASF added a comment - The ASF releases source, and projects must provide links to download that source which must be served from the ASF mirror system. The http://maven.apache.org/download.cgi download page does that for the Maven product. There needs to be a download link for the source to each plugin as well. The plugins can share a page, but the main Maven page is already long enough so I don't think their links belong there.
        Hide
        Karl-Heinz Marbaise added a comment - - edited

        Hi,
        after thinking about your request i've got the following idea. The plugins will provide a link to the following location:

        https://dist.apache.org/repos/dist/release/maven/plugins/${project.artifactId}-${project.version}-source-release.zip
        

        which will look like this for the maven-assembly-plugin:

        https://dist.apache.org/repos/dist/release/maven/plugins/maven-assembly-plugin-2.4-source-release.zip
        

        Is that what you have in mind?

        Show
        Karl-Heinz Marbaise added a comment - - edited Hi, after thinking about your request i've got the following idea. The plugins will provide a link to the following location: https: //dist.apache.org/repos/dist/release/maven/plugins/${project.artifactId}-${project.version}-source-release.zip which will look like this for the maven-assembly-plugin: https: //dist.apache.org/repos/dist/release/maven/plugins/maven-assembly-plugin-2.4-source-release.zip Is that what you have in mind?
        Hide
        Karl-Heinz Marbaise added a comment -

        Hi,

        can you check the example site which Hervé has created:

        http://maven.apache.org/plugins-archives/maven-scm-publish-plugin-LATEST/

        WDYT ?

        Show
        Karl-Heinz Marbaise added a comment - Hi, can you check the example site which Hervé has created: http://maven.apache.org/plugins-archives/maven-scm-publish-plugin-LATEST/ WDYT ?
        Hide
        SebbASF added a comment -

        Example looks fine to me.

        Show
        SebbASF added a comment - Example looks fine to me.
        Hide
        Karl-Heinz Marbaise added a comment -

        Fixed in r1593809

        Show
        Karl-Heinz Marbaise added a comment - Fixed in r1593809
        Karl-Heinz Marbaise made changes -
        Resolution Fixed [ 1 ]
        Assignee Karl-Heinz Marbaise [ khmarbaise ]
        Status Open [ 1 ] Closed [ 6 ]
        Hide
        Herve Boutemy added a comment -

        misunderstanding, r1593809 is not sufficient:

        • dowload.xdoc and download.cgi as prepared in maven-scm-publish-plugin need to be copied in every Maven sub-project
        • the fix need to be applied in every Maven sub-project, not just plugins: shared, ... see dist-tool source release report for the complete list
        Show
        Herve Boutemy added a comment - misunderstanding, r1593809 is not sufficient: dowload.xdoc and download.cgi as prepared in maven-scm-publish-plugin need to be copied in every Maven sub-project the fix need to be applied in every Maven sub-project, not just plugins: shared, ... see dist-tool source release report for the complete list
        Karl-Heinz Marbaise made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Karl-Heinz Marbaise added a comment - - edited

        Added the download.cgi and xdoc/download.xml.vm into all plugins with the state of last change in maven-scm-publish-plugin.
        Done in 1594666.

        Show
        Karl-Heinz Marbaise added a comment - - edited Added the download.cgi and xdoc/download.xml.vm into all plugins with the state of last change in maven-scm-publish-plugin. Done in 1594666 .
        Hide
        Karl-Heinz Marbaise added a comment -

        Added download.cgi and xdoc/download.xml.vm for org.apache.maven.shared 1594676.
        Added missing links in site.xml for org.apache.maven.shared 1594680.

        Show
        Karl-Heinz Marbaise added a comment - Added download.cgi and xdoc/download.xml.vm for org.apache.maven.shared 1594676 . Added missing links in site.xml for org.apache.maven.shared 1594680 .
        Hide
        Karl-Heinz Marbaise added a comment -

        Hi, can you check this example which is created a few hours ago if it fits the needs?
        http://maven.apache.org/plugins-archives/maven-ear-plugin-LATEST/

        Show
        Karl-Heinz Marbaise added a comment - Hi, can you check this example which is created a few hours ago if it fits the needs? http://maven.apache.org/plugins-archives/maven-ear-plugin-LATEST/
        Hide
        SebbASF added a comment -

        Looks good to me.

        The License link is to the correct page, and it is placed just above the download link, which means it should be obvious to people wishing to use the software.

        The download page also has a clear link to the source archive, plus sig and hash.
        The links don't actually work, but I assume that is because 2.9.1 has yet to be released.
        If I change 2.9.1 to 2.9 then the links do work OK.

        Show
        SebbASF added a comment - Looks good to me. The License link is to the correct page, and it is placed just above the download link, which means it should be obvious to people wishing to use the software. The download page also has a clear link to the source archive, plus sig and hash. The links don't actually work, but I assume that is because 2.9.1 has yet to be released. If I change 2.9.1 to 2.9 then the links do work OK.
        Hide
        Karl-Heinz Marbaise added a comment -

        The links work not cause as you mentioned cause 2.9.1 is not released yet. Just VOTE started. Thanks for the feedback.

        Show
        Karl-Heinz Marbaise added a comment - The links work not cause as you mentioned cause 2.9.1 is not released yet. Just VOTE started. Thanks for the feedback.

          People

          • Assignee:
            Karl-Heinz Marbaise
            Reporter:
            SebbASF
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated: