[mng] NPE in Embedder when resolving system dependency

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.0.11
  • Fix Version/s: None
  • Component/s: Maven Embedder
  • Labels:
    None

Description

dependency resolver fail in some cases when system scope dependency is used

java.lang.NullPointerException
at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:107)
at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:76)
at org.maven.ide.eclipse.embedder.EclipseArtifactResolver.resolve(EclipseArtifactResolver.java:57)
at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:539)
at org.apache.maven.project.DefaultMavenProjectBuilder.buildWithDependencies(DefaultMavenProjectBuilder.java:350)
at org.apache.maven.embedder.MavenEmbedder.readProjectWithDependencies(MavenEmbedder.java:466)
at org.maven.ide.eclipse.embedder.MavenModelManager.readMavenProject(MavenModelManager.java:377)
at org.maven.ide.eclipse.embedder.BuildPathManager.resolveClasspathEntries(BuildPathManager.java:232)
at org.maven.ide.eclipse.embedder.BuildPathManager.updateClasspathContainer(BuildPathManager.java:193)
at org.maven.ide.eclipse.container.Maven2Builder.build(Maven2Builder.java:92)
at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:624)
...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eugene Kuleshov added a comment -

Jason, can you please take a look at this

Show
Eugene Kuleshov added a comment - Jason, can you please take a look at this
Hide
Permalink
John Casey added a comment -

Currently, system scope and system path will not be injected into transitive dependencies from the dependencyManagement map. These options are only injected into first-level dependencies (direct dependencies) when the project instance is created. For transitive dependencies, only the versions are passed through the transitive graph. The attached example project has a dependencyManagement element for xerces, but only directly declares a dependency on jaxen...if xerces is a transitive dependency brought in by jaxen, it's scope and systemPath will not be set.

Show
John Casey added a comment - Currently, system scope and system path will not be injected into transitive dependencies from the dependencyManagement map. These options are only injected into first-level dependencies (direct dependencies) when the project instance is created. For transitive dependencies, only the versions are passed through the transitive graph. The attached example project has a dependencyManagement element for xerces, but only directly declares a dependency on jaxen...if xerces is a transitive dependency brought in by jaxen, it's scope and systemPath will not be set.
Hide
Permalink
Eugene Kuleshov added a comment -

John, if using system dependencies in dependency management is not supported then it should give a clear error, but not the NPE.

Show
Eugene Kuleshov added a comment - John, if using system dependencies in dependency management is not supported then it should give a clear error, but not the NPE.
Hide
Permalink
John Casey added a comment -

yeah, that is an interesting point that it seems to be starting to look at it as if it were a system dep...back to the code, I guess.

Show
John Casey added a comment - yeah, that is an interesting point that it seems to be starting to look at it as if it were a system dep...back to the code, I guess.
Hide
Permalink
John Casey added a comment -

the NPE should be fixed in the newest snapshot of maven-artifact.

Show
John Casey added a comment - the NPE should be fixed in the newest snapshot of maven-artifact.
Hide
Permalink
John Casey added a comment -

Eugene, is this still happening?

Show
John Casey added a comment - Eugene, is this still happening?
Hide
Permalink
Eugene Kuleshov added a comment -

In my recollection, there is no NPE anymore, but dependency is not resolved anyways, but I need to check that again to be sure.

Show
Eugene Kuleshov added a comment - In my recollection, there is no NPE anymore, but dependency is not resolved anyways, but I need to check that again to be sure.
Hide
Permalink
Eugene Kuleshov added a comment - - edited

John, for those test projects I am getting error: "Missing indirectly referenced artifact xerces:xercesImpl:jar:2.7.1:system"

I guess it is because of the following declaration in the parent pom, but not sure how to make it work without using ${basedir}. Note that xerces is just an example and users been trying to use proprietary libraries that they can't or don't want to put into Maven repository.

<dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>xerces</groupId>
        <artifactId>xercesImpl</artifactId>
        <version>2.7.1</version>
        <scope>system</scope>
        <systemPath>$\{basedir\}/lib/xercesImpl-2.7.1.jar</systemPath>
      </dependency>
    </dependencies>
  </dependencyManagement>
Show
Eugene Kuleshov added a comment - - edited John, for those test projects I am getting error: "Missing indirectly referenced artifact xerces:xercesImpl:jar:2.7.1:system" I guess it is because of the following declaration in the parent pom, but not sure how to make it work without using ${basedir}. Note that xerces is just an example and users been trying to use proprietary libraries that they can't or don't want to put into Maven repository. 
<dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>xerces</groupId>
        <artifactId>xercesImpl</artifactId>
        <version>2.7.1</version>
        <scope>system</scope>
        <systemPath>$\{basedir\}/lib/xercesImpl-2.7.1.jar</systemPath>
      </dependency>
    </dependencies>
  </dependencyManagement>

People

  • Assignee:
    Unassigned
    Reporter:
    Eugene Kuleshov
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: