Maven Integration for Eclipse

Strange Behaviour in TransferListenerAdapter

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: 0.0.11
  • Fix Version/s: None
  • Component/s: Dependency Resolver
  • Labels:
    None
  • Number of attachments :
    1

Description

I have seen that the M2-Console print out the same message multiple times:

11:37:02 CEST: Downloaded Repositoryfornax.repository/org/openarchitectureware/oaw-core-xpand2/4.1.1/oaw-core-xpand2-4.1.1.jar
09.04.07 11:37:04 CEST: Downloaded Repositoryfornax.repository/org/openarchitectureware/oaw-core-xpand2/4.1.1/oaw-core-xpand2-4.1.1.jar
09.04.07 11:37:06 CEST: Downloaded Repositoryfornax.repository/org/openarchitectureware/oaw-core-xpand2/4.1.1/oaw-core-xpand2-4.1.1.jar

After some debugging I see that the TransferListernerAdapter is created 3 times. I think the problem is the parameter " Maven2Console console" needed by the constructor of the TransferListenerAdapter. There is only one Maven2Console, so if an event occurs that use the TransferListernerAdapter every added Listener is called. As a result the same message will be printed out 3 times.

Another problem with this TransferListenerAdapter is that often the ProgressView shows:
200% downloading ...

This i have fixed with an if (see the patch).
But the StringBuilder in the method transferProgress i have reactivated shows corious results:
11:37:02 CEST: 145/146K
09.04.07 11:37:02 CEST: 73/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 75/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 76/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 146/146K
09.04.07 11:37:02 CEST: 77/146K

You see there are really curious results.

Issue Links

This issue duplicates:
MNGECLIPSE-302 Plugin tries to download dependencies N times Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Stefan Seidel added a comment -

Thorsten, why do you think that the problem is with the Maven2Console? It is used within the TransferListener only to print out some messages. Can you see my comment for MNGECLIPSE-302 where I describe the problem, too?

Show
Stefan Seidel added a comment - Thorsten, why do you think that the problem is with the Maven2Console? It is used within the TransferListener only to print out some messages. Can you see my comment for MNGECLIPSE-302 where I describe the problem, too?
Hide
Permalink
Thorsten Kamann added a comment -

This was only a guess. All other objects exists multiple times...The Maven2Console is always the same.
I don't know whether the ProgressMonitor shows to much...this you can't see, because there is only one line where messages were printed out.

Show
Thorsten Kamann added a comment - This was only a guess. All other objects exists multiple times...The Maven2Console is always the same. I don't know whether the ProgressMonitor shows to much...this you can't see, because there is only one line where messages were printed out.
Hide
Permalink
Abel Muiņo added a comment -

This is marked as a duplicate of MNGECLIPSE-302, which has been resolved.

Shouldn't this bug be closed as well?

Show
Abel Muiņo added a comment - This is marked as a duplicate of MNGECLIPSE-302, which has been resolved. Shouldn't this bug be closed as well?
Hide
Permalink
Derek Clarkson added a comment -

I've just checked out the latest from trunk, built it and updated eclipse.

The bug is not fixed in trunk !

It's improved and not taking as long to resolve files. But I am still getting multiple messages, lucene lock messages and it is still taking a long time to handle each file.

Show
Derek Clarkson added a comment - I've just checked out the latest from trunk, built it and updated eclipse. The bug is not fixed in trunk ! It's improved and not taking as long to resolve files. But I am still getting multiple messages, lucene lock messages and it is still taking a long time to handle each file.
Hide
Permalink
Abel Muiņo added a comment -

Would it be possible to have a test project and the maven settings you're using to build it? Seeing exactly what you get would help to really fix the problem.

Show
Abel Muiņo added a comment - Would it be possible to have a test project and the maven settings you're using to build it? Seeing exactly what you get would help to really fix the problem.
Hide
Permalink
Eugene Kuleshov added a comment -

I can't reproduce this. Please feel free to reopen if you still experience this with 0.0.11 and attach sample project that we could use to reproduce. Thanks.

Show
Eugene Kuleshov added a comment - I can't reproduce this. Please feel free to reopen if you still experience this with 0.0.11 and attach sample project that we could use to reproduce. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.