Version numbers are compared as strings

I somehow missed this patch. Can someone update it to the latest code? Thanks.

I reworked the patch
but instead of writing a version comparator, I used Maven's one: org.apache.maven.artifact.versioning.DefaultArtifactVersion

Thanks Herve. Unfortunately with your patch version 1.0-alpha-7 is compared bigger then 1.0-alpha-44 (e.g. in plexus-container-default artifact).

yes, version comparison in Maven is broken: there is a proposal to completely rewrite it http://docs.codehaus.org/display/MAVEN/Versioning

the question is: should m2eclipse be bug-compatible with Maven or try to fix things?

fixing things in Maven core would even be better, but there is a constraint: should not change the API
I'll look at the topic later

Because of the API issues, it probably doesn't make sense to bind to the Maven version.

I worked on code from the proposal, and submitted it for review on Maven dev list.
The code is here http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010, with its unit test http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java

We can wait for the comparator to be integrated in Maven core (which can take some time), or I can integrate immediately a copy of the code in m2eclipse to test it against every library found by the indexer, either in trunk or a branch.
What do you prefer?

Isn't your proposal affects the present Maven behavior? If so, then I think it would be better to have it implemented in m2eclipse for now.

using DefaultArtifactVersion in r389
this immediately provides correct version comparison for version schemes strictly supported by Maven (x.y.z)
enhancements for other version schemes is in progress in MNG-3010, not committed yet to trunk

fixed for indexes view too in r402

Herve, is there anything left in this issue?

code is fixed: 10.2 is now > 2.0

but 1.0-alpha-7 is still compared bigger then 1.0-alpha-44: we need to update artifact snapshot to use fixes available in it

as you wish: we can consider this issue fixed or not

Herve, I updated Maven embedder from trunk. Sorting in artifact search dialog is working fine now, but I am getting the error below for artifact org.eclipse:emf:2.3.0-v200706262000 when opening "org" folder for central repository in "Maven Indexes" view.

You can easily reproduce this in the unit test with something like checkVersionsOrder( "2.3.0-v200706262000", "2.3.0-v200706262130" ); and also verify similar combinations like 2.3.0.v200706262000, 2.3.0.qualifier, 2.3.0.1234, with ".", "-" and "_" delimiters.

Also, it is quite noticeable that new artifact parser is much slower. Can you make it initialize lazily, e.g. only for the first comparison operation?

java.lang.NumberFormatException: For input string: "200706262000"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
at java.lang.Integer.parseInt(Integer.java:459)
at java.lang.Integer.<init>(Integer.java:620)
at org.apache.maven.artifact.versioning.ComparableVersion.parseItem(ComparableVersion.java:412)
at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:398)
at org.apache.maven.artifact.versioning.ComparableVersion.<init>(ComparableVersion.java:312)
at org.apache.maven.artifact.versioning.DefaultArtifactVersion.parseVersion(DefaultArtifactVersion.java:95)
at org.apache.maven.artifact.versioning.DefaultArtifactVersion.<init>(DefaultArtifactVersion.java:47)
at org.maven.ide.eclipse.index.IndexedArtifactFile.<init>(IndexedArtifactFile.java:55)
at org.maven.ide.eclipse.internal.index.NexusIndexManager.getIndexedArtifactFile(NexusIndexManager.java:354)
at org.maven.ide.eclipse.internal.index.NexusIndexManager.search(NexusIndexManager.java:259)
at org.maven.ide.eclipse.index.IndexManager.resolveGroup(IndexManager.java:285)
at org.maven.ide.eclipse.internal.views.MavenIndexesView$ViewContentProvider.getChildren(MavenIndexesView.java:529)
...

ok, maven-artifact now works for 2.3.0-v200706262000 version

do you have any real artifact with an underscore? Nothing is implemented for this...

Verified. It is working great now. Thanks Herve.